Skip to content

chore: update major bc changes references #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shortcuts merged 4 commits into from
Dec 18, 2024
Merged

chore: update major bc changes references #4188

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ec37b1
chore: update major bc changes references
shortcuts Dec 2, 2024
f790f8a
chore: index exists
shortcuts Dec 2, 2024
5e19f78
Update specs/major-breaking-changes-rename.json
shortcuts Dec 18, 2024
29f33c0
Merge branch 'main' into chore/major-breaking-changes-renames
shortcuts Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions specs/major-breaking-changes-rename.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"client.getTopUserIDs": "client.getTopUserIds",
"client.getUserID": "client.getUserId",
"client.listApiKeys": "client.listApiKeys",
"client.listIndexes": "client.listIndices",
"client.listIndices": "client.listIndices",
"client.listUserIDs": "client.listUserIds",
"client.moveIndex": "client.operationIndex",
Expand All @@ -56,6 +57,7 @@
"index.deleteObjects": "client.deleteObjects",
"index.deleteRule": "client.deleteRule",
"index.deleteSynonym": "client.deleteSynonym",
"index.exists": "client.indexExists",
Copy link
Contributor

@millotp millotp Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4010

Copy link
Member Author

@shortcuts shortcuts Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kai687 can we just not generate the link for it? it's still great to let users that can use an LSP/IDE benefit from the inline documentation

Copy link
Member Author

@shortcuts shortcuts Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kai687

"index.findObject": "client.searchSingleIndex",
"index.getObject": "client.getObject",
"index.getObjects": "client.getObjects",
Expand Down