From 6be66a6ef5ff7e3c5de92ce19220a0b2cbfe08a0 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 14:06:24 +0100 Subject: [PATCH 1/6] fix(javascript): allow async param on createIterablePromise --- .../src/createIterablePromise.ts | 19 +++++++++++-------- .../src/types/createIterablePromise.ts | 10 +++++----- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/clients/algoliasearch-client-javascript/packages/client-common/src/createIterablePromise.ts b/clients/algoliasearch-client-javascript/packages/client-common/src/createIterablePromise.ts index 1c1d2503972..c9ba843d28d 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/src/createIterablePromise.ts +++ b/clients/algoliasearch-client-javascript/packages/client-common/src/createIterablePromise.ts @@ -20,22 +20,25 @@ export function createIterablePromise({ const retry = (previousResponse?: TResponse): Promise => { return new Promise((resolve, reject) => { func(previousResponse) - .then((response) => { + .then(async (response) => { if (aggregator) { - aggregator(response); + await aggregator(response); } - if (validate(response)) { + if (await validate(response)) { return resolve(response); } - if (error && error.validate(response)) { - return reject(new Error(error.message(response))); + if (error && (await error.validate(response))) { + return reject(new Error(await error.message(response))); } - return setTimeout(() => { - retry(response).then(resolve).catch(reject); - }, timeout()); + return setTimeout( + () => { + retry(response).then(resolve).catch(reject); + }, + await timeout(), + ); }) .catch((err) => { reject(err); diff --git a/clients/algoliasearch-client-javascript/packages/client-common/src/types/createIterablePromise.ts b/clients/algoliasearch-client-javascript/packages/client-common/src/types/createIterablePromise.ts index 1d414b89b12..62178b9e14b 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/src/types/createIterablePromise.ts +++ b/clients/algoliasearch-client-javascript/packages/client-common/src/types/createIterablePromise.ts @@ -2,7 +2,7 @@ export type IterableOptions = Partial<{ /** * The function that runs right after the API call has been resolved, allows you to do anything with the response before `validate`. */ - aggregator: (response: TResponse) => void; + aggregator: (response: TResponse) => unknown | PromiseLike; /** * The `validate` condition to throw an error and its message. @@ -11,18 +11,18 @@ export type IterableOptions = Partial<{ /** * The function to validate the error condition. */ - validate: (response: TResponse) => boolean; + validate: (response: TResponse) => boolean | PromiseLike; /** * The error message to throw. */ - message: (response: TResponse) => string; + message: (response: TResponse) => string | PromiseLike; }; /** * The function to decide how long to wait between iterations. */ - timeout: () => number; + timeout: () => number | PromiseLike; }>; export type CreateIterablePromise = IterableOptions & { @@ -36,5 +36,5 @@ export type CreateIterablePromise = IterableOptions & { /** * The validator function. It receive the resolved return of the API call. */ - validate: (response: TResponse) => boolean; + validate: (response: TResponse) => boolean | PromiseLike; }; From c2b8a33de89bab4ff5ba953e5b317edaa0ad40ae Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 15:01:18 +0100 Subject: [PATCH 2/6] not working --- .../packages/client-common/package.json | 2 +- .../cache/browser-local-storage-cache.test.ts | 2 +- .../__tests__/create-iterable-promise.test.ts | 20 +++++++++++++++++++ .../packages/client-common/tsconfig.json | 5 +++-- .../packages/logger-console/package.json | 2 +- .../packages/logger-console/tsconfig.json | 5 +++-- .../requester-browser-xhr/package.json | 2 +- .../__tests__/browser-xhr-requester.test.ts | 2 +- .../requester-browser-xhr/tsconfig.json | 5 +++-- .../packages/requester-fetch/package.json | 2 +- .../src/__tests__/fetch-requester.test.ts | 2 +- .../packages/requester-fetch/tsconfig.json | 5 +++-- .../packages/requester-node-http/package.json | 2 +- .../src/__tests__/node-http-requester.test.ts | 2 +- .../requester-node-http/tsconfig.json | 5 +++-- playground/javascript/node/ingestion.ts | 2 +- templates/javascript/clients/package.mustache | 2 +- 17 files changed, 46 insertions(+), 21 deletions(-) diff --git a/clients/algoliasearch-client-javascript/packages/client-common/package.json b/clients/algoliasearch-client-javascript/packages/client-common/package.json index a4353061e36..26f7de72bc3 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/package.json +++ b/clients/algoliasearch-client-javascript/packages/client-common/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "vitest --run", + "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", "test:bundle": "publint . && attw --pack ." }, "devDependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/cache/browser-local-storage-cache.test.ts b/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/cache/browser-local-storage-cache.test.ts index 646733773d6..f35c28dc61f 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/cache/browser-local-storage-cache.test.ts +++ b/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/cache/browser-local-storage-cache.test.ts @@ -91,7 +91,7 @@ describe('browser local storage cache', () => { await cache.clear(); - const defaultValue = (): Promise => Promise.resolve({ bar: 2 }); + const defaultValue = (): Promise<{ bar: number }> => Promise.resolve({ bar: 2 }); expect(localStorage.length).toBe(0); diff --git a/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/create-iterable-promise.test.ts b/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/create-iterable-promise.test.ts index 418a49636cb..4043115865a 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/create-iterable-promise.test.ts +++ b/clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/create-iterable-promise.test.ts @@ -53,6 +53,26 @@ describe('createIterablePromise', () => { await expect(promise).resolves.toEqual(3); expect(calls).toBe(3); }); + + test('allow async function', async () => { + createIterablePromise({ + func: () => { + return Promise.resolve({ + hits: [], + cursor: '', + }); + }, + validate: async () => { + return await Promise.resolve(true); + }, + aggregator: async (res) => { + return await Promise.resolve(res); + }, + timeout: async () => { + return await Promise.resolve(1000); + }, + }); + }); }); describe('aggregator', () => { diff --git a/clients/algoliasearch-client-javascript/packages/client-common/tsconfig.json b/clients/algoliasearch-client-javascript/packages/client-common/tsconfig.json index 969849e2c44..f6efa884545 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/tsconfig.json +++ b/clients/algoliasearch-client-javascript/packages/client-common/tsconfig.json @@ -2,8 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "types": ["node", "vitest/globals"], - "outDir": "dist" + "outDir": "dist", + "skipLibCheck": true }, "include": ["src"], - "exclude": ["dist", "node_modules", "src/__tests__"] + "exclude": ["dist", "node_modules"] } diff --git a/clients/algoliasearch-client-javascript/packages/logger-console/package.json b/clients/algoliasearch-client-javascript/packages/logger-console/package.json index ffcfb00448f..23314f67e11 100644 --- a/clients/algoliasearch-client-javascript/packages/logger-console/package.json +++ b/clients/algoliasearch-client-javascript/packages/logger-console/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "vitest --run", + "test": "tsc --noEmit__tests__/* && vitest --run", "test:bundle": "publint . && attw --pack ." }, "devDependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/logger-console/tsconfig.json b/clients/algoliasearch-client-javascript/packages/logger-console/tsconfig.json index ff374efa6c5..a9a49694a48 100644 --- a/clients/algoliasearch-client-javascript/packages/logger-console/tsconfig.json +++ b/clients/algoliasearch-client-javascript/packages/logger-console/tsconfig.json @@ -2,8 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "types": ["node", "vitest/globals"], - "outDir": "dist" + "outDir": "dist", + "skipLibCheck": true }, "include": ["src", "index.ts"], - "exclude": ["dist", "node_modules", "src/__tests__"] + "exclude": ["dist", "node_modules"] } diff --git a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json index f505ce24cd4..4d32795a29d 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json @@ -27,7 +27,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "vitest --run", + "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", "test:bundle": "publint . && attw --pack . --ignore-rules cjs-resolves-to-esm" }, "dependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/__tests__/browser-xhr-requester.test.ts b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/__tests__/browser-xhr-requester.test.ts index 4239ea21859..18861987466 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/__tests__/browser-xhr-requester.test.ts +++ b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/__tests__/browser-xhr-requester.test.ts @@ -114,7 +114,7 @@ describe('timeout handling', () => { afterAll( () => - new Promise((done) => { + new Promise((done) => { done(); }), ); diff --git a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/tsconfig.json b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/tsconfig.json index 969849e2c44..f6efa884545 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/tsconfig.json +++ b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/tsconfig.json @@ -2,8 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "types": ["node", "vitest/globals"], - "outDir": "dist" + "outDir": "dist", + "skipLibCheck": true }, "include": ["src"], - "exclude": ["dist", "node_modules", "src/__tests__"] + "exclude": ["dist", "node_modules"] } diff --git a/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json b/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json index b9fb2d4f056..0ca8f68df79 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json @@ -43,7 +43,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "vitest --run", + "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", "test:bundle": "publint . && attw --pack ." }, "dependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts b/clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts index f25b26d8991..91be2e6aa2e 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts +++ b/clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts @@ -108,7 +108,7 @@ describe('timeout handling', () => { afterAll( () => - new Promise((done) => { + new Promise((done) => { done(); }), ); diff --git a/clients/algoliasearch-client-javascript/packages/requester-fetch/tsconfig.json b/clients/algoliasearch-client-javascript/packages/requester-fetch/tsconfig.json index 969849e2c44..f6efa884545 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-fetch/tsconfig.json +++ b/clients/algoliasearch-client-javascript/packages/requester-fetch/tsconfig.json @@ -2,8 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "types": ["node", "vitest/globals"], - "outDir": "dist" + "outDir": "dist", + "skipLibCheck": true }, "include": ["src"], - "exclude": ["dist", "node_modules", "src/__tests__"] + "exclude": ["dist", "node_modules"] } diff --git a/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json b/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json index 04e9b891cef..c857d8a51c2 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "vitest --run", + "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", "test:bundle": "publint . && attw --pack ." }, "dependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts b/clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts index 7f852ac911f..9ff3e9ca060 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts +++ b/clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts @@ -164,7 +164,7 @@ describe('timeout handling', () => { afterAll( () => - new Promise((done) => { + new Promise((done) => { done(); }), ); diff --git a/clients/algoliasearch-client-javascript/packages/requester-node-http/tsconfig.json b/clients/algoliasearch-client-javascript/packages/requester-node-http/tsconfig.json index 969849e2c44..f6efa884545 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-node-http/tsconfig.json +++ b/clients/algoliasearch-client-javascript/packages/requester-node-http/tsconfig.json @@ -2,8 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "types": ["node", "vitest/globals"], - "outDir": "dist" + "outDir": "dist", + "skipLibCheck": true }, "include": ["src"], - "exclude": ["dist", "node_modules", "src/__tests__"] + "exclude": ["dist", "node_modules"] } diff --git a/playground/javascript/node/ingestion.ts b/playground/javascript/node/ingestion.ts index ae1d302b4bd..af1c188f633 100644 --- a/playground/javascript/node/ingestion.ts +++ b/playground/javascript/node/ingestion.ts @@ -1,4 +1,4 @@ -import { ApiError } from '@algolia/client-common'; +import { ApiError, createIterablePromise } from '@algolia/client-common'; import { ingestionClient } from '@algolia/ingestion'; const appId = process.env.ALGOLIA_APPLICATION_ID || '**** APP_ID *****'; diff --git a/templates/javascript/clients/package.mustache b/templates/javascript/clients/package.mustache index e11d21921ce..492515680d7 100644 --- a/templates/javascript/clients/package.mustache +++ b/templates/javascript/clients/package.mustache @@ -11,7 +11,7 @@ "build": "yarn clean && yarn tsup && yarn rollup -c rollup.config.js", "clean": "rm -rf ./dist || true", {{#isAlgoliasearchClient}} - "test": "vitest --run", + "test": "tsc --noEmit && vitest --run", {{/isAlgoliasearchClient}} "test:bundle": "publint . && attw --pack ." }, From f1119190fa624509fb89f2c9e5da4cab4a58be75 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 15:02:17 +0100 Subject: [PATCH 3/6] not working From 8bc8c9f641bcaba469652a72aef5057d9f9ea25f Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 15:04:26 +0100 Subject: [PATCH 4/6] template --- playground/javascript/node/ingestion.ts | 2 +- templates/javascript/clients/package.mustache | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/playground/javascript/node/ingestion.ts b/playground/javascript/node/ingestion.ts index af1c188f633..ae1d302b4bd 100644 --- a/playground/javascript/node/ingestion.ts +++ b/playground/javascript/node/ingestion.ts @@ -1,4 +1,4 @@ -import { ApiError, createIterablePromise } from '@algolia/client-common'; +import { ApiError } from '@algolia/client-common'; import { ingestionClient } from '@algolia/ingestion'; const appId = process.env.ALGOLIA_APPLICATION_ID || '**** APP_ID *****'; diff --git a/templates/javascript/clients/package.mustache b/templates/javascript/clients/package.mustache index 492515680d7..c0907022945 100644 --- a/templates/javascript/clients/package.mustache +++ b/templates/javascript/clients/package.mustache @@ -11,7 +11,7 @@ "build": "yarn clean && yarn tsup && yarn rollup -c rollup.config.js", "clean": "rm -rf ./dist || true", {{#isAlgoliasearchClient}} - "test": "tsc --noEmit && vitest --run", + "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", {{/isAlgoliasearchClient}} "test:bundle": "publint . && attw --pack ." }, From 5d18c717733b335dbc5dd6368f79e48c39dce22b Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 15:10:14 +0100 Subject: [PATCH 5/6] ok --- .../packages/client-common/package.json | 2 +- .../packages/logger-console/package.json | 2 +- .../packages/requester-browser-xhr/package.json | 2 +- .../packages/requester-fetch/package.json | 2 +- .../packages/requester-node-http/package.json | 2 +- templates/javascript/clients/package.mustache | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/clients/algoliasearch-client-javascript/packages/client-common/package.json b/clients/algoliasearch-client-javascript/packages/client-common/package.json index 26f7de72bc3..0027fc8680c 100644 --- a/clients/algoliasearch-client-javascript/packages/client-common/package.json +++ b/clients/algoliasearch-client-javascript/packages/client-common/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", + "test": "tsc --noEmit && vitest --run", "test:bundle": "publint . && attw --pack ." }, "devDependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/logger-console/package.json b/clients/algoliasearch-client-javascript/packages/logger-console/package.json index 23314f67e11..de959473a07 100644 --- a/clients/algoliasearch-client-javascript/packages/logger-console/package.json +++ b/clients/algoliasearch-client-javascript/packages/logger-console/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "tsc --noEmit__tests__/* && vitest --run", + "test": "tsc --noEmit && vitest --run", "test:bundle": "publint . && attw --pack ." }, "devDependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json index 4d32795a29d..ea349342d55 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json @@ -27,7 +27,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", + "test": "tsc --noEmit && vitest --run", "test:bundle": "publint . && attw --pack . --ignore-rules cjs-resolves-to-esm" }, "dependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json b/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json index 0ca8f68df79..78a53faa950 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-fetch/package.json @@ -43,7 +43,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", + "test": "tsc --noEmit && vitest --run", "test:bundle": "publint . && attw --pack ." }, "dependencies": { diff --git a/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json b/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json index c857d8a51c2..435d16cd0f3 100644 --- a/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json +++ b/clients/algoliasearch-client-javascript/packages/requester-node-http/package.json @@ -30,7 +30,7 @@ "scripts": { "build": "yarn clean && yarn tsup", "clean": "rm -rf ./dist || true", - "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", + "test": "tsc --noEmit && vitest --run", "test:bundle": "publint . && attw --pack ." }, "dependencies": { diff --git a/templates/javascript/clients/package.mustache b/templates/javascript/clients/package.mustache index c0907022945..6394a32c502 100644 --- a/templates/javascript/clients/package.mustache +++ b/templates/javascript/clients/package.mustache @@ -11,7 +11,7 @@ "build": "yarn clean && yarn tsup && yarn rollup -c rollup.config.js", "clean": "rm -rf ./dist || true", {{#isAlgoliasearchClient}} - "test": "tsc --noEmit src/__tests__/**/*.ts && vitest --run", + "test": "tsc --noEmit && vitest --run", {{/isAlgoliasearchClient}} "test:bundle": "publint . && attw --pack ." }, @@ -145,4 +145,4 @@ "engines": { "node": ">= 14.0.0" } -} \ No newline at end of file +} From 5e3a69e9adb9b5d150c85df116076c4f521fdce4 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Fri, 22 Nov 2024 15:25:39 +0100 Subject: [PATCH 6/6] custom tsconfig for algoliasearch --- .../packages/algoliasearch/__tests__/tsconfig.json | 8 ++++++++ templates/javascript/clients/package.mustache | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/tsconfig.json diff --git a/clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/tsconfig.json b/clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/tsconfig.json new file mode 100644 index 00000000000..b719fa625db --- /dev/null +++ b/clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/tsconfig.json @@ -0,0 +1,8 @@ +{ + "extends": "../tsconfig.json", + "compilerOptions": { + "noEmit": true, + "skipLibCheck": true + }, + "include": ["*.ts"] +} diff --git a/templates/javascript/clients/package.mustache b/templates/javascript/clients/package.mustache index 6394a32c502..d7a0b5f6fc1 100644 --- a/templates/javascript/clients/package.mustache +++ b/templates/javascript/clients/package.mustache @@ -11,7 +11,7 @@ "build": "yarn clean && yarn tsup && yarn rollup -c rollup.config.js", "clean": "rm -rf ./dist || true", {{#isAlgoliasearchClient}} - "test": "tsc --noEmit && vitest --run", + "test": "tsc -p __tests__/tsconfig.json && vitest --run", {{/isAlgoliasearchClient}} "test:bundle": "publint . && attw --pack ." },