From 4250dfb9d9c0a169091639e88746f1f45f418657 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Thu, 10 Oct 2024 00:33:13 +0200 Subject: [PATCH 1/2] fix(specs): correct type for banners --- specs/common/schemas/IndexSettings.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/specs/common/schemas/IndexSettings.yml b/specs/common/schemas/IndexSettings.yml index c1490318d40..995ed8c0712 100644 --- a/specs/common/schemas/IndexSettings.yml +++ b/specs/common/schemas/IndexSettings.yml @@ -1036,9 +1036,8 @@ banners: description: banners defined in the merchandising studio for the given search. type: array additionalProperties: false - properties: - banners: - $ref: '#/banner' + items: + $ref: '#/banner' banner: description: a search banner with image and url. @@ -1064,13 +1063,15 @@ bannerImage: additionalProperties: false properties: urls: - $ref: '#/bannerImageUrl' + type: array + items: + $ref: '#/bannerImageUrl' title: type: string bannerImageUrl: description: url for a search banner image. - type: array + type: object additionalProperties: false properties: url: From ce7c589b6600ed9f5aca1467697123caf8b28746 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Thu, 10 Oct 2024 00:42:54 +0200 Subject: [PATCH 2/2] banners alias to an array --- .../main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java | 1 - .../javascript/clients/algoliasearch/builds/models.mustache | 2 -- 2 files changed, 3 deletions(-) diff --git a/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java b/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java index af9c867aeac..1d35c4a7896 100644 --- a/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java +++ b/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java @@ -42,7 +42,6 @@ public class AlgoliaSwiftGenerator extends Swift5ClientCodegen { "bannerimage", "bannerimageurl", "bannerlink", - "banners", "baseindexsettings", "basesearchparams", "basesearchparamswithoutquery", diff --git a/templates/javascript/clients/algoliasearch/builds/models.mustache b/templates/javascript/clients/algoliasearch/builds/models.mustache index ac93e8ae154..1829c343dec 100644 --- a/templates/javascript/clients/algoliasearch/builds/models.mustache +++ b/templates/javascript/clients/algoliasearch/builds/models.mustache @@ -16,7 +16,6 @@ import type { BannerImage, BannerImageUrl, BannerLink, - Banners, BaseIndexSettings, BaseSearchParams, BaseSearchParamsWithoutQuery, @@ -112,7 +111,6 @@ export { BannerImage, BannerImageUrl, BannerLink, - Banners, BaseIndexSettings, BaseSearchParams, BaseSearchParamsWithoutQuery,