Skip to content

Commit bc8460c

Browse files
shortcutskai687millotp
authored
chore(specs): change oneOf order for docs (#5676)
Co-authored-by: Kai Welke <kai.welke@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
1 parent aa28ea5 commit bc8460c

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

scripts/update_jira_token.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

33
# This script updates the JIRA_TOKEN secret in the GitHub repository
44
# Usage: ./scripts/update_jira_token.sh <jira_email> <new_jira_token>
55

6-
if [ "$#" -ne 1 ]; then
6+
if [ "$#" -ne 2 ]; then
77
echo "Usage: $0 <jira_email> <new_jira_token>"
88
exit 1
99
fi

specs/common/schemas/SearchParams.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ baseSearchParamsWithoutQuery:
106106

107107
searchParamsString:
108108
type: object
109-
title: Search parameters as query string.
109+
title: Search parameters as query string
110110
description: Search parameters as query string.
111111
additionalProperties: false
112112
x-discriminator-fields:

specs/search/common/schemas/BrowseParams.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
browseParams:
22
oneOf:
3+
- title: Search parameters as object
4+
$ref: '#/browseParamsObject'
35
- $ref: '../../../common/schemas/SearchParams.yml#/searchParamsString'
4-
- $ref: '#/browseParamsObject'
56

67
browseParamsObject:
78
allOf:

tests/CTS/requests/search/browse.json

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,21 @@
5757
"cursor": "test"
5858
}
5959
}
60+
},
61+
{
62+
"testName": "browse with query string",
63+
"parameters": {
64+
"indexName": "indexName",
65+
"browseParams": {
66+
"params": "foo=bar&cursor=test"
67+
}
68+
},
69+
"request": {
70+
"path": "/1/indexes/indexName/browse",
71+
"method": "POST",
72+
"body": {
73+
"params": "foo=bar&cursor=test"
74+
}
75+
}
6076
}
6177
]

0 commit comments

Comments
 (0)