feat(clients): cleanup after replaceAllObjects failure [skip-bc] (#3824) (generated) [skip ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>

Author: 3 people

clients/algoliasearch-client-csharp/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-dart/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-go/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-go/algolia/search/api_search.go

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-java/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -6572,24 +6572,6 @@ public <T> List<BatchResponse> chunkedBatch(
     return chunkedBatch(indexName, objects, action, waitForTasks, 1000, requestOptions);
   }
 
-  /**
-   * Push a new set of objects and remove all previous ones. Settings, synonyms and query rules are
-   * untouched. Replace all records in an index without any downtime. See
-   * https://api-clients-automation.netlify.app/docs/add-new-api-client#5-helpers for implementation
-   * details.
-   *
-   * @param indexName The `indexName` to replace `objects` in.
-   * @param objects The array of `objects` to store in the given Algolia `indexName`.
-   * @param batchSize The size of the chunk of `objects`. The number of `batch` calls will be equal
-   *     to `length(objects) / batchSize`.
-   * @throws AlgoliaRetryException When the retry has failed on all hosts
-   * @throws AlgoliaApiException When the API sends an http error code
-   * @throws AlgoliaRuntimeException When an error occurred during the serialization
-   */
-  public <T> ReplaceAllObjectsResponse replaceAllObjects(String indexName, Iterable<T> objects, int batchSize) {
-    return replaceAllObjects(indexName, objects, batchSize, null);
-  }
-
   /**
    * Helper: Saves the given array of objects in the given index. The `chunkedBatch` helper is used
    * under the hood, which creates a `batch` requests with at most 1000 objects in it.
@@ -6822,6 +6804,40 @@ public <T> List<BatchResponse> partialUpdateObjects(
     );
   }
 
+  /**
+   * Push a new set of objects and remove all previous ones. Settings, synonyms and query rules are
+   * untouched. Replace all records in an index without any downtime. See
+   * https://api-clients-automation.netlify.app/docs/add-new-api-client#5-helpers for implementation
+   * details.
+   *
+   * @param indexName The `indexName` to replace `objects` in.
+   * @param objects The array of `objects` to store in the given Algolia `indexName`.
+   * @throws AlgoliaRetryException When the retry has failed on all hosts
+   * @throws AlgoliaApiException When the API sends an http error code
+   * @throws AlgoliaRuntimeException When an error occurred during the serialization
+   */
+  public <T> ReplaceAllObjectsResponse replaceAllObjects(String indexName, Iterable<T> objects) {
+    return replaceAllObjects(indexName, objects, -1);
+  }
+
+  /**
+   * Push a new set of objects and remove all previous ones. Settings, synonyms and query rules are
+   * untouched. Replace all records in an index without any downtime. See
+   * https://api-clients-automation.netlify.app/docs/add-new-api-client#5-helpers for implementation
+   * details.
+   *
+   * @param indexName The `indexName` to replace `objects` in.
+   * @param objects The array of `objects` to store in the given Algolia `indexName`.
+   * @param batchSize The size of the chunk of `objects`. The number of `batch` calls will be equal
+   *     to `length(objects) / batchSize`.
+   * @throws AlgoliaRetryException When the retry has failed on all hosts
+   * @throws AlgoliaApiException When the API sends an http error code
+   * @throws AlgoliaRuntimeException When an error occurred during the serialization
+   */
+  public <T> ReplaceAllObjectsResponse replaceAllObjects(String indexName, Iterable<T> objects, int batchSize) {
+    return replaceAllObjects(indexName, objects, batchSize, null);
+  }
+
   /**
    * Push a new set of objects and remove all previous ones. Settings, synonyms and query rules are
    * untouched. Replace all records in an index without any downtime. See
@@ -6847,47 +6863,57 @@ public <T> ReplaceAllObjectsResponse replaceAllObjects(
     Random rnd = new Random();
     String tmpIndexName = indexName + "_tmp_" + rnd.nextInt(100);
 
-    // Copy settings, synonyms and rules
-    UpdatedAtResponse copyOperationResponse = operationIndex(
-      indexName,
-      new OperationIndexParams()
-        .setOperation(OperationType.COPY)
-        .setDestination(tmpIndexName)
-        .addScope(ScopeType.SETTINGS)
-        .addScope(ScopeType.RULES)
-        .addScope(ScopeType.SYNONYMS),
-      requestOptions
-    );
+    if (batchSize == -1) {
+      batchSize = 1000;
+    }
 
-    // Save new objects
-    List<BatchResponse> batchResponses = chunkedBatch(tmpIndexName, objects, Action.ADD_OBJECT, true, batchSize, requestOptions);
+    try {
+      // Copy settings, synonyms and rules
+      UpdatedAtResponse copyOperationResponse = operationIndex(
+        indexName,
+        new OperationIndexParams()
+          .setOperation(OperationType.COPY)
+          .setDestination(tmpIndexName)
+          .addScope(ScopeType.SETTINGS)
+          .addScope(ScopeType.RULES)
+          .addScope(ScopeType.SYNONYMS),
+        requestOptions
+      );
 
-    waitForTask(tmpIndexName, copyOperationResponse.getTaskID(), requestOptions);
+      // Save new objects
+      List<BatchResponse> batchResponses = chunkedBatch(tmpIndexName, objects, Action.ADD_OBJECT, true, batchSize, requestOptions);
 
-    copyOperationResponse = operationIndex(
-      indexName,
-      new OperationIndexParams()
-        .setOperation(OperationType.COPY)
-        .setDestination(tmpIndexName)
-        .addScope(ScopeType.SETTINGS)
-        .addScope(ScopeType.RULES)
-        .addScope(ScopeType.SYNONYMS),
-      requestOptions
-    );
-    waitForTask(tmpIndexName, copyOperationResponse.getTaskID(), requestOptions);
+      waitForTask(tmpIndexName, copyOperationResponse.getTaskID(), requestOptions);
 
-    // Move temporary index to source index
-    UpdatedAtResponse moveOperationResponse = operationIndex(
-      tmpIndexName,
-      new OperationIndexParams().setOperation(OperationType.MOVE).setDestination(indexName),
-      requestOptions
-    );
-    waitForTask(tmpIndexName, moveOperationResponse.getTaskID(), requestOptions);
+      copyOperationResponse = operationIndex(
+        indexName,
+        new OperationIndexParams()
+          .setOperation(OperationType.COPY)
+          .setDestination(tmpIndexName)
+          .addScope(ScopeType.SETTINGS)
+          .addScope(ScopeType.RULES)
+          .addScope(ScopeType.SYNONYMS),
+        requestOptions
+      );
+      waitForTask(tmpIndexName, copyOperationResponse.getTaskID(), requestOptions);
+
+      // Move temporary index to source index
+      UpdatedAtResponse moveOperationResponse = operationIndex(
+        tmpIndexName,
+        new OperationIndexParams().setOperation(OperationType.MOVE).setDestination(indexName),
+        requestOptions
+      );
+      waitForTask(tmpIndexName, moveOperationResponse.getTaskID(), requestOptions);
+
+      return new ReplaceAllObjectsResponse()
+        .setCopyOperationResponse(copyOperationResponse)
+        .setBatchResponses(batchResponses)
+        .setMoveOperationResponse(moveOperationResponse);
+    } catch (Exception e) {
+      deleteIndex(tmpIndexName);
 
-    return new ReplaceAllObjectsResponse()
-      .setCopyOperationResponse(copyOperationResponse)
-      .setBatchResponses(batchResponses)
-      .setMoveOperationResponse(moveOperationResponse);
+      throw e;
+    }
   }
 
   /**

clients/algoliasearch-client-java/algoliasearch/src/main/java/com/algolia/api/SearchClient.java

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-javascript/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -642,57 +642,63 @@ export function createSearchClient({
       const randomSuffix = Math.floor(Math.random() * 1000000) + 100000;
       const tmpIndexName = `${indexName}_tmp_${randomSuffix}`;
 
-      let copyOperationResponse = await this.operationIndex(
-        {
-          indexName,
-          operationIndexParams: {
-            operation: 'copy',
-            destination: tmpIndexName,
-            scope: ['settings', 'rules', 'synonyms'],
+      try {
+        let copyOperationResponse = await this.operationIndex(
+          {
+            indexName,
+            operationIndexParams: {
+              operation: 'copy',
+              destination: tmpIndexName,
+              scope: ['settings', 'rules', 'synonyms'],
+            },
           },
-        },
-        requestOptions,
-      );
+          requestOptions,
+        );
 
-      const batchResponses = await this.chunkedBatch(
-        { indexName: tmpIndexName, objects, waitForTasks: true, batchSize },
-        requestOptions,
-      );
+        const batchResponses = await this.chunkedBatch(
+          { indexName: tmpIndexName, objects, waitForTasks: true, batchSize },
+          requestOptions,
+        );
 
-      await this.waitForTask({
-        indexName: tmpIndexName,
-        taskID: copyOperationResponse.taskID,
-      });
+        await this.waitForTask({
+          indexName: tmpIndexName,
+          taskID: copyOperationResponse.taskID,
+        });
 
-      copyOperationResponse = await this.operationIndex(
-        {
-          indexName,
-          operationIndexParams: {
-            operation: 'copy',
-            destination: tmpIndexName,
-            scope: ['settings', 'rules', 'synonyms'],
+        copyOperationResponse = await this.operationIndex(
+          {
+            indexName,
+            operationIndexParams: {
+              operation: 'copy',
+              destination: tmpIndexName,
+              scope: ['settings', 'rules', 'synonyms'],
+            },
           },
-        },
-        requestOptions,
-      );
-      await this.waitForTask({
-        indexName: tmpIndexName,
-        taskID: copyOperationResponse.taskID,
-      });
+          requestOptions,
+        );
+        await this.waitForTask({
+          indexName: tmpIndexName,
+          taskID: copyOperationResponse.taskID,
+        });
 
-      const moveOperationResponse = await this.operationIndex(
-        {
+        const moveOperationResponse = await this.operationIndex(
+          {
+            indexName: tmpIndexName,
+            operationIndexParams: { operation: 'move', destination: indexName },
+          },
+          requestOptions,
+        );
+        await this.waitForTask({
           indexName: tmpIndexName,
-          operationIndexParams: { operation: 'move', destination: indexName },
-        },
-        requestOptions,
-      );
-      await this.waitForTask({
-        indexName: tmpIndexName,
-        taskID: moveOperationResponse.taskID,
-      });
+          taskID: moveOperationResponse.taskID,
+        });
 
-      return { copyOperationResponse, batchResponses, moveOperationResponse };
+        return { copyOperationResponse, batchResponses, moveOperationResponse };
+      } catch (error) {
+        await this.deleteIndex({ indexName: tmpIndexName });
+
+        throw error;
+      }
     },
 
     async indexExists({ indexName }: GetSettingsProps): Promise<boolean> {

clients/algoliasearch-client-javascript/packages/client-search/src/searchClient.ts

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing

clients/algoliasearch-client-kotlin/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -27,7 +27,7 @@ body:
     id: client
     attributes:
       label: Client
-      description: Which API are you targetting?
+      description: Which API are you targeting?
       options:
         - All
         - AB testing