Return the original response if attempt to parse JSONL file fails

Author: alexrudall

lib/openai/http.rb

@@ -44,12 +44,15 @@ def parse_json(response)
       return unless response
       return response unless response.is_a?(String)
 
+      original_response = response.dup
       if response.include?("}\n{")
-        # Convert a multiline string of JSON objects to a JSON array.
+        # Attempt to convert what looks like a multiline string of JSON objects to a JSON array.
         response = response.gsub("}\n{", "},{").prepend("[").concat("]")
       end
 
-      try_parse_json(response)
+      JSON.parse(response)
+    rescue JSON::ParserError
+      original_response
     end
 
     # Given a proc, returns an outer proc that can be used to iterate over a JSON stream of chunks.

spec/openai/client/http_spec.rb

@@ -196,6 +196,15 @@
 
       it { expect(parsed).to eq([{ "prompt" => ":)" }, { "prompt" => ":(" }]) }
     end
+
+    context "with a non-json string containing newline-brace pattern" do
+      let(:body) { "Hello}\n{World" }
+      let(:parsed) { OpenAI::Client.new.send(:parse_json, body) }
+
+      it "returns the original string when JSON parsing fails" do
+        expect(parsed).to eq("Hello}\n{World")
+      end
+    end
   end
 
   describe ".uri" do