Skip to content

Commit 5dd675f

Browse files
Metadata refactoring (#42)
Further refactoring metadata logic
1 parent e729852 commit 5dd675f

File tree

21 files changed

+298
-375
lines changed

21 files changed

+298
-375
lines changed

database/api/src/main/java/com/albertoventurini/graphdbplugin/database/api/query/GraphQueryResultRow.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.albertoventurini.graphdbplugin.database.api.data.GraphRelationship;
1111

1212
import java.util.List;
13-
import java.util.Optional;
1413

1514
public interface GraphQueryResultRow {
1615

testing/integration-neo4j/src/test/java/com/albertoventurini/graphdbplugin/test/integration/neo4j/tests/database/common/AbstractDataSourceMetadataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
package com.albertoventurini.graphdbplugin.test.integration.neo4j.tests.database.common;
88

99
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.DataSourceMetadata;
10-
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.Neo4jProcedureMetadata;
10+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jProcedureMetadata;
1111
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.state.DataSourceApi;
1212
import com.albertoventurini.graphdbplugin.test.integration.neo4j.util.base.BaseIntegrationTest;
1313

testing/integration-neo4j/src/test/java/com/albertoventurini/graphdbplugin/test/integration/neo4j/tests/database/neo4j/DataSourceMetadataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
package com.albertoventurini.graphdbplugin.test.integration.neo4j.tests.database.neo4j;
88

99
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.DataSourceMetadata;
10-
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.Neo4jFunctionMetadata;
10+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jFunctionMetadata;
1111
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.state.DataSourceApi;
1212
import com.albertoventurini.graphdbplugin.test.integration.neo4j.tests.database.common.AbstractDataSourceMetadataTest;
1313

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/datasource/metadata/DataSourceMetadata.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,20 @@
66
*/
77
package com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata;
88

9+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jConstraintMetadata;
10+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jFunctionMetadata;
11+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jIndexMetadata;
12+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jProcedureMetadata;
13+
914
import java.util.List;
10-
import java.util.Map;
1115

1216
public interface DataSourceMetadata {
1317

14-
List<Map<String, String>> getMetadata(String metadataKey);
15-
1618
List<Neo4jFunctionMetadata> getFunctions();
1719

1820
List<Neo4jProcedureMetadata> getProcedures();
1921

2022
List<Neo4jIndexMetadata> getIndexes();
2123

22-
boolean isMetadataExists(String metadataKey);
24+
List<Neo4jConstraintMetadata> getConstraints();
2325
}

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/datasource/metadata/DataSourcesComponentMetadata.java

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,23 @@
77
package com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata;
88

99
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.DataSourceType;
10+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jBoltCypherDataSourceMetadata;
11+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jLabelMetadata;
12+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jMetadataBuilder;
13+
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.metadata.neo4j.Neo4jRelationshipTypeMetadata;
1014
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.state.DataSourceApi;
11-
import com.albertoventurini.graphdbplugin.jetbrains.database.DatabaseManagerService;
1215
import com.albertoventurini.graphdbplugin.jetbrains.services.ExecutorService;
1316
import com.albertoventurini.graphdbplugin.jetbrains.ui.datasource.metadata.MetadataRetrieveEvent;
1417
import com.intellij.openapi.application.ApplicationManager;
15-
import com.intellij.openapi.diagnostic.Logger;
1618
import com.intellij.openapi.project.Project;
1719
import com.intellij.util.messages.MessageBus;
18-
import com.albertoventurini.graphdbplugin.database.api.GraphDatabaseApi;
19-
import com.albertoventurini.graphdbplugin.database.api.query.GraphQueryResult;
20-
import com.albertoventurini.graphdbplugin.database.api.query.GraphQueryResultColumn;
2120
import com.albertoventurini.graphdbplugin.language.cypher.completion.metadata.CypherMetadataContainer;
2221
import com.albertoventurini.graphdbplugin.language.cypher.completion.metadata.CypherMetadataProviderService;
2322

2423
import java.util.HashMap;
25-
import java.util.List;
2624
import java.util.Map;
2725
import java.util.Optional;
2826
import java.util.concurrent.CompletableFuture;
29-
import java.util.function.Function;
30-
import java.util.stream.Collectors;
31-
32-
import static java.util.stream.Collectors.toList;
3327

3428
public class DataSourcesComponentMetadata {
3529

@@ -80,16 +74,14 @@ private void updateNeo4jBoltMetadata(DataSourceApi dataSource, Neo4jBoltCypherDa
8074

8175
metadata.getLabels()
8276
.stream()
83-
.map(Neo4jLabelMetadata::getName)
77+
.map(Neo4jLabelMetadata::name)
8478
.forEach(container::addLabel);
8579
metadata.getRelationshipTypes()
8680
.stream()
87-
.map(Neo4jRelationshipTypeMetadata::getName)
81+
.map(Neo4jRelationshipTypeMetadata::name)
8882
.forEach(container::addRelationshipType);
89-
metadata.getMetadata(Neo4jBoltCypherDataSourceMetadata.PROPERTY_KEYS).stream()
90-
.map((row) -> row.get("propertyKey"))
91-
.forEach(container::addPropertyKey);
9283

84+
metadata.getPropertyKeys().forEach(container::addPropertyKey);
9385
metadata.getProcedures().forEach(p -> container.addProcedure(p.name(), p.signature(), p.description()));
9486
metadata.getFunctions().forEach(f -> container.addFunction(f.name(), f.signature(), f.description()));
9587
}

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/datasource/metadata/MetadataBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
import com.albertoventurini.graphdbplugin.jetbrains.component.datasource.state.DataSourceApi;
44

5-
interface MetadataBuilder {
5+
public interface MetadataBuilder {
66
DataSourceMetadata buildMetadata(DataSourceApi dataSource);
77
}

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/datasource/metadata/Neo4jBoltCypherDataSourceMetadata.java

Lines changed: 0 additions & 160 deletions
This file was deleted.

ui/jetbrains/src/main/java/com/albertoventurini/graphdbplugin/jetbrains/component/datasource/metadata/Neo4jLabelMetadata.java

Lines changed: 0 additions & 33 deletions
This file was deleted.

0 commit comments

Comments
 (0)