Use bufhidden=wipe for Scratch diff buffers

[Voltron369]

Prevents [NoName] Scratch buffers from accumulating:

proposed code change:

M autoload/gitgutter.vim
@@ -259,6 +259,8 @@ function! gitgutter#difforig()
 
   vertical new
   set buftype=nofile
+ if v:version >= 800
+     setlocal bufhidden=wipe
+ endif
+ setlocal noswapfile
   let &filetype = filetype
 
   if g:gitgutter_diff_relative_to ==# 'index'
@@ -273,6 +275,7 @@ function! gitgutter#difforig()
 
   0d_
   diffthis
+  setlocal nomodifiable
   wincmd p
   diffthis
 endfunction

[airblade]

This is deviating from the the DiffOrig command in defaults.vim:

https://github.com/vim/vim/blob/a4c43a6cf54b1916339641439b74f05499a4d9dd/runtime/defaults.vim#L148-L149

I try to stay consistent with Vim's commands where possible.

Having said that it seems like a useful addition.

As far as I can tell wipe was available in Vim 7.0 – do you think otherwise?

[Voltron369]

As far as I can tell wipe was available in Vim 7.0 – do you think otherwise?

It does seem to be in version 7, but not 100% sure it was bug free...

[airblade]

git log --grep wipe prints this among other things:

e8ef3a093 Wed Oct 12 17:45:29 2016 +0200 patch 8.0.0031 Problem:    After ":bwipeout" 'fileformat' is not set to the right default. Solution:   Get the default from 'fileformats'. (Mike Williams) (tag: v8.0.0031)
e0ab94e71 Sun Sep 4 19:50:54 2016 +0200 patch 7.4.2324 Problem:    Crash when editing a new buffer and BufUnload autocommand wipes out the new buffer. (Norio Takagi) Solution:   Don't allow wiping out this buffer. (partly by Hirohito Higashi)  Move old style test13 into test_autocmd. Avoid ml_get error when editing a file. (tag: v7.4.2324)
4c7ab1bb5 Sun Apr 6 20:45:43 2014 +0200 updated for version 7.4.251 Problem:    Crash when BufAdd autocommand wipes out the buffer. Solution:   Check for buffer to still be valid. Postpone freeing the buffer structure. (Hirohito Higashi) (tag: v7.4.251)
a02471e29 Fri Jan 10 16:43:14 2014 +0100 updated for version 7.4.140 Problem:    Crash when wiping out buffer triggers autocommand that wipes out only other buffer. Solution:   Do not delete the last buffer, make it empty. (Hirohito Higashi (tag: v7.4.140)
c93df6b07 Wed Aug 14 17:11:20 2013 +0200 updated for version 7.4.004 Problem:    When closing a window fails ":bwipe" may hang. Solution:   Let win_close() return FAIL and break out of the loop. (tag: v7.4.004)
9e931224d Wed Jun 20 11:55:01 2012 +0200 updated for version 7.3.557 Problem:    Crash when an autocommand wipes out a buffer when it is hidden. Solution:   Restore the current window when needed. (Christian Brabandt) (tag: v7.3.557)
8006d69d3 Tue Mar 2 17:23:21 2010 +0100 updated for version 7.2.382 Problem:    Accessing freed memory when closing the cmdline window when 'bufhide' is set to "wipe". Solution:   Check if the buffer still exists before invoking close_buffer() (Dominique Pelle) (tag: v7.2.382)

Anyway, happy to merge a PR with a v8 guard.