removing download_shards param

Author: mgonzs13

include/huggingface_hub.h

@@ -107,15 +107,13 @@ hf_hub_download(const std::string &repo_id, const std::string &filename,
  * "~/.cache/huggingface/hub".
  * @param force_download If true, forces the download even if the file already
  * exists in the cache.
- * @param download_shards If true, download model shards using regex to find
- * the amount of shards the model is splitted into.
  * @return A DownloadResult structure containing the success status and the path
  * of the downloaded file.
  */
 struct DownloadResult hf_hub_download_with_shards(
     const std::string &repo_id, const std::string &filename,
     const std::string &cache_dir = "~/.cache/huggingface/hub",
-    bool force_download = false, bool download_shards = true);
+    bool force_download = false);
 
 #endif // HUGGINGFACE_HUB_H
 } // namespace huggingface_hub

src/huggingface_hub.cpp

@@ -377,37 +377,33 @@ struct DownloadResult hf_hub_download(const std::string &repo_id,
 struct DownloadResult hf_hub_download_with_shards(const std::string &repo_id,
                                                   const std::string &filename,
                                                   const std::string &cache_dir,
-                                                  bool force_download,
-                                                  bool download_shards) {
+                                                  bool force_download) {
 
-  if (download_shards) {
+  std::regex pattern(R"(-([0-9]+)-of-([0-9]+)\.gguf)");
+  std::smatch match;
 
-    std::regex pattern(R"(-([0-9]+)-of-([0-9]+)\.gguf)");
-    std::smatch match;
+  if (std::regex_search(filename, match, pattern)) {
+    int total_shards = std::stoi(match[2]);
+    std::string base_name = filename.substr(0, match.position(0));
 
-    if (std::regex_search(filename, match, pattern)) {
-      int total_shards = std::stoi(match[2]);
-      std::string base_name = filename.substr(0, match.position(0));
+    // Download shards
+    for (int i = 1; i <= total_shards; ++i) {
+      char shard_file[256];
+      snprintf(shard_file, sizeof(shard_file), "%s-%05d-of-%05d.gguf",
+               base_name.c_str(), i, total_shards);
+      auto aux_res =
+          hf_hub_download(repo_id, shard_file, cache_dir, force_download);
 
-      // Download shards
-      for (int i = 1; i <= total_shards; ++i) {
-        char shard_file[256];
-        snprintf(shard_file, sizeof(shard_file), "%s-%05d-of-%05d.gguf",
-                 base_name.c_str(), i, total_shards);
-        auto aux_res =
-            hf_hub_download(repo_id, shard_file, cache_dir, force_download);
-
-        if (!aux_res.success) {
-          return aux_res;
-        }
+      if (!aux_res.success) {
+        return aux_res;
       }
-
-      // Return first shard
-      char first_shard[256];
-      snprintf(first_shard, sizeof(first_shard), "%s-00001-of-%05d.gguf",
-               base_name.c_str(), total_shards);
-      return hf_hub_download(repo_id, first_shard, cache_dir, false);
     }
+
+    // Return first shard
+    char first_shard[256];
+    snprintf(first_shard, sizeof(first_shard), "%s-00001-of-%05d.gguf",
+             base_name.c_str(), total_shards);
+    return hf_hub_download(repo_id, first_shard, cache_dir, false);
   }
 
   return hf_hub_download(repo_id, filename, cache_dir, force_download);