Add filtering for active experiments (#25)

Author: adinhodovic

django_google_optimize/__init__.py

@@ -0,0 +1 @@
+default_app_config = "django_google_optimize.apps.DjangoGoogleOptimizeConfig"

django_google_optimize/apps.py

@@ -0,0 +1,6 @@
+from django.apps import AppConfig
+
+
+class DjangoGoogleOptimizeConfig(AppConfig):
+    name = "django_google_optimize"
+    verbose_name = "Google Optimize"

django_google_optimize/utils.py

@@ -7,7 +7,7 @@
 
 # pylint: disable=too-many-return-statements
 def get_experiments_variants(request):
-    experiments = GoogleExperiment.objects.all()
+    experiments = GoogleExperiment.objects.filter(active=True)
     if not experiments:
         logger.warning("No experiment added")
         return None

tests/test_helpers.py

@@ -10,7 +10,7 @@ class Meta:
 
     experiment_id = factory.Faker("sha1")
     experiment_alias = factory.Faker("city")
-    active = False
+    active = True
 
 
 # pylint: disable=too-few-public-methods

tests/test_utils.py

@@ -139,6 +139,17 @@ def test_parses_experiments_without_variant_alias():
     exp = GoogleExperimentFactory()
     variant = ExperimentVariantFactory(index=1, alias=None, experiment=exp)
     request = HttpRequest()
-    request.COOKIES["_gaexp"] = f"GAX1.2.{exp.experiment_id}.18147.1"
+    request.COOKIES["_gaexp"] = f"GAX1.2.{exp.experiment_id}.18147.{variant.index}"
     values = get_experiments_variants(request)
     assert values == {exp.experiment_alias: variant.index}
+
+
+@pytest.mark.django_db
+def test_filters_active_experiments():
+    exp = GoogleExperimentFactory()
+    GoogleExperimentFactory(active=False)
+    variant = ExperimentVariantFactory(index=1, experiment=exp)
+    request = HttpRequest()
+    request.COOKIES["_gaexp"] = f"GAX1.2.{exp.experiment_id}.18147.{variant.index}"
+    values = get_experiments_variants(request)
+    assert values == {exp.experiment_alias: variant.alias}