fixup! Add cookie overriding/adding (#26)

Author: adinhodovic

django_google_optimize/utils.py

@@ -52,9 +52,6 @@ def get_experiments_variants(request):
                     "No experiment variant added with the index %s", variant_name
                 )
                 return None
-        else:
-            logger.warning("No variants added")
-            return None
 
         experiment_alias = experiment.experiment_alias
         if experiment_alias:

tests/test_utils.py

@@ -63,16 +63,6 @@ def test_logs_failed_cookie_parsing(logger):
     logger.assert_called_with("Failed to parse _gaexp %s", "test")
 
 
-@pytest.mark.django_db
-@mock.patch("logging.Logger.warning")
-def test_logs_no_variants(logger):
-    exp = GoogleExperimentFactory()
-    request = HttpRequest()
-    request.COOKIES["_gaexp"] = f"GAX1.2.{exp.experiment_id}.18147.1"
-    get_experiments_variants(request)
-    logger.assert_called_with("No variants added")
-
-
 @pytest.mark.django_db
 @mock.patch("logging.Logger.warning")
 def test_logs_no_experiment_variant(logger):
@@ -128,6 +118,15 @@ def test_parses_multiple_experiments():
     }
 
 
+@pytest.mark.django_db
+def test_parses_experiments_variants():
+    exp = GoogleExperimentFactory()
+    request = HttpRequest()
+    request.COOKIES["_gaexp"] = f"GAX1.2.{exp.experiment_id}.18147.1"
+    values = get_experiments_variants(request)
+    assert values == {exp.experiment_alias: 1}
+
+
 @pytest.mark.django_db
 def test_parses_experiments_without_experiment_alias():
     exp = GoogleExperimentFactory(experiment_alias=None)