Fix variant increment overflow.

adamfranco · adamfranco · commit 07c135dd5ff5 · 2022-02-09T00:15:22.000-05:00
diff --git a/OpenMapSamplesControl.js b/OpenMapSamplesControl.js
@@ -387,7 +387,7 @@ export default class SampleControl {
   }
 
   incrementVariant(sample) {
-    if (this._variantSelect.selectedIndex < this._variantSelect.options.length) {
+    if (this._variantSelect.selectedIndex < this._variantSelect.options.length - 1) {
       this._variantSelect.selectedIndex = this._variantSelect.selectedIndex + 1;
       this.changeVariant(sample);
     }

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ export default class SampleControl {`
`387`	`387`	`}`
`388`	`388`
`389`	`389`	`incrementVariant(sample) {`
`390`		`- if (this._variantSelect.selectedIndex < this._variantSelect.options.length) {`
	`390`	`+ if (this._variantSelect.selectedIndex < this._variantSelect.options.length - 1) {`
`391`	`391`	`this._variantSelect.selectedIndex = this._variantSelect.selectedIndex + 1;`
`392`	`392`	`this.changeVariant(sample);`
`393`	`393`	`}`