fixed CodeRabbit issues involving zod schema and certain functions

Author: AdityaK2905

eslint.config.mjs

@@ -39,6 +39,10 @@ export default defineConfig([
           alwaysTryTypes: true,
           project: ["src/api/tsconfig.json", "src/ui/tsconfig.json"],
         },
+        node: {
+          paths: ["src/api", "src/ui"],
+          extensions: [".js", ".ts", ".jsx", ".tsx"],
+        },
       },
     },
 

src/api/functions/stripe.ts

@@ -362,15 +362,23 @@ export const checkOrCreateCustomer = async ({
   customerName,
   stripeApiKey,
 }: checkCustomerParams): Promise<CheckOrCreateResult> => {
+  const normalizedEmail = customerEmail.trim().toLowerCase();
+  const [, domainPart] = normalizedEmail.split("@");
+
+  if (!domainPart) {
+    throw new Error(`Could not derive email domain for "${customerEmail}".`);
+  }
+
+  const normalizedDomain = domainPart.toLowerCase();
+
   const lock = createLock({
     adapter: new IoredisAdapter(redisClient),
-    key: `stripe:${acmOrg}:${emailDomain}`,
+    key: `stripe:${acmOrg}:${normalizedDomain}`,
     retryAttempts: 5,
     retryDelay: 300,
   }) as SimpleLock;
 
-  const pk = `${acmOrg}#${emailDomain}`;
-  const normalizedEmail = customerEmail.trim().toLowerCase();
+  const pk = `${acmOrg}#${normalizedDomain}`;
 
   return await lock.using(async () => {
     const checkCustomer = new QueryCommand({
@@ -511,11 +519,19 @@ export const addInvoice = async ({
   dynamoClient,
   stripeApiKey,
 }: InvoiceAddParams): Promise<CheckOrCreateResult> => {
-  const pk = `${acmOrg}#${emailDomain}`;
+  const normalizedEmail = contactEmail.trim().toLowerCase();
+  const [, domainPart] = normalizedEmail.split("@");
+
+  if (!domainPart) {
+    throw new Error(`Could not derive email domain for "${contactEmail}".`);
+  }
+
+  const normalizedDomain = domainPart.toLowerCase();
+  const pk = `${acmOrg}#${normalizedDomain}`;
 
   const result = await checkOrCreateCustomer({
     acmOrg,
-    emailDomain,
+    emailDomain: normalizedDomain,
     redisClient,
     dynamoClient,
     customerEmail: contactEmail,
@@ -541,7 +557,11 @@ export const addInvoice = async ({
             },
             { removeUndefinedValues: true },
           ),
+          ConditionExpression:
+            "attribute_not_exists(primaryKey) AND attribute_not_exists(sortKey)",
         },
+      },
+      {
         Update: {
           TableName: genericConfig.StripePaymentsDynamoTableName,
           Key: {

src/api/package.json

@@ -15,14 +15,14 @@
     "prettier:write": "prettier --write *.ts **/*.ts"
   },
   "dependencies": {
-    "@aws-sdk/s3-request-presigner": "^3.914.0",
-    "@aws-sdk/client-s3": "^3.914.0",
     "@aws-sdk/client-dynamodb": "^3.922.0",
     "@aws-sdk/client-lambda": "^3.922.0",
+    "@aws-sdk/client-s3": "^3.922.0",
     "@aws-sdk/client-secrets-manager": "^3.922.0",
     "@aws-sdk/client-ses": "^3.922.0",
     "@aws-sdk/client-sqs": "^3.922.0",
     "@aws-sdk/client-sts": "^3.922.0",
+    "@aws-sdk/s3-request-presigner": "^3.922.0",
     "@aws-sdk/signature-v4-crt": "^3.922.0",
     "@aws-sdk/util-dynamodb": "^3.922.0",
     "@azure/msal-node": "^3.8.1",
@@ -75,4 +75,4 @@
     "pino-pretty": "^13.1.1",
     "yaml": "^2.8.1"
   }
-}
+}

src/api/routes/stripe.ts

@@ -150,12 +150,21 @@ const stripeRoutes: FastifyPluginAsync = async (fastify, _options) => {
         });
       }
 
+      const stripe = new Stripe(secretApiConfig.stripe_secret_key as string);
+
+      const dynamicPrice = await stripe.prices.create({
+        unit_amount: request.body.invoiceAmountUsd * 100, // USD → cents
+        currency: "usd",
+        product_data: {
+          name: `Invoice ${request.body.invoiceId}`,
+        },
+      });
       const checkoutUrl = await createCheckoutSessionWithCustomer({
         customerId: result.customerId,
         stripeApiKey: secretApiConfig.stripe_secret_key as string,
         items: [
           {
-            price: "<PRICE_ID_OR_DYNAMICALLY_CREATED_PRICE>",
+            price: dynamicPrice.id,
             quantity: 1,
           },
         ],

src/common/types/stripe.ts

@@ -2,7 +2,7 @@ import * as z from "zod/v4";
 
 export const invoiceLinkPostResponseSchema = z.object({
   id: z.string().min(1),
-  link: z.string().url()
+  link: z.string().url(),
 });
 
 export const invoiceLinkPostRequestSchema = z.object({
@@ -22,7 +22,7 @@ export type PostInvoiceLinkResponse = z.infer<
 
 export const createInvoicePostResponseSchema = z.object({
   id: z.string().min(1),
-  link: z.url()
+  link: z.url(),
 });
 
 export const createInvoiceConflictResponseSchema = z.object({
@@ -53,15 +53,17 @@ export const createInvoicePostRequestSchema = z.object({
   invoiceAmountUsd: z.number().min(50),
   contactName: z.string().min(1),
   contactEmail: z.email(),
-  acmOrg: z.string().min(1)
+  acmOrg: z.string().min(1),
 });
 
 export type PostCreateInvoiceRequest = z.infer<
-  typeof createInvoicePostRequestSchema>;
+  typeof createInvoicePostRequestSchema
+>;
 
 
 export type PostCreateInvoiceResponse = z.infer<
-  typeof createInvoicePostResponseSchema>;
+  typeof createInvoicePostResponseSchema
+>;
 
 export const invoiceLinkGetResponseSchema = z.array(
   z.object({
@@ -71,9 +73,10 @@ export const invoiceLinkGetResponseSchema = z.array(
     active: z.boolean(),
     invoiceId: z.string().min(1),
     invoiceAmountUsd: z.number().min(50),
-    createdAt: z.union([z.string().datetime(), z.null()])
+    createdAt: z.union([z.string().datetime(), z.null()]),
   })
 );
 
 export type GetInvoiceLinksResponse = z.infer<
-  typeof invoiceLinkGetResponseSchema>;
+  typeof invoiceLinkGetResponseSchema
+>;