add no-amd-name fixer

Author: acdvs

lib/rules/no-amd-name.js

@@ -11,22 +11,34 @@
 
 module.exports = {
   meta: {
-    type: 'problem',
+    type: 'suggestion',
     messages: {
       noModuleName: 'No AMD module name should be provided'
-    }
+    },
+    fixable: 'code'
   },
 
   create: function(context) {
     return {
       'CallExpression[callee.name=define]': function(node) {
+        if (node.arguments.length !== 3) {
+          return;
+        }
+
+        const arg1 = node.arguments[0];
+        const arg2 = node.arguments[1];
+
         if (
-          node.arguments[0].type === 'Literal' &&
-          typeof node.arguments[0].value === 'string'
+          arg1 &&
+          arg1.type === 'Literal' &&
+          typeof arg1.value === 'string'
         ) {
           context.report({
-            node: node.arguments[0],
-            messageId: 'noModuleName'
+            node: arg1,
+            messageId: 'noModuleName',
+            fix: function(fixer) {
+              return fixer.replaceTextRange([arg1.start, arg2.start], '');
+            }
           });
         }
       }

tests/rules/no-amd-name.js

@@ -29,25 +29,25 @@ ruleTester.run('no-amd-name', rule, {
     },
     {
       code: 'define(["N/search"], function(search) {});'
+    },
+    {
+      code: 'define("moduleName");'
+    },
+    {
+      code: 'define("moduleName", ["N/search"]);'
     }
   ],
 
   invalid: [
     {
       code: 'define("moduleName", [], function() {});',
-      errors: [{ messageId: 'noModuleName' }]
+      errors: [{ messageId: 'noModuleName' }],
+      output: 'define([], function() {});'
     },
     {
       code: 'define("moduleName", ["N/search"], function(search) {});',
-      errors: [{ messageId: 'noModuleName' }]
-    },
-    {
-      code: 'define("moduleName");',
-      errors: [{ messageId: 'noModuleName' }]
-    },
-    {
-      code: 'define("moduleName", ["N/search"]);',
-      errors: [{ messageId: 'noModuleName' }]
+      errors: [{ messageId: 'noModuleName' }],
+      output: 'define(["N/search"], function(search) {});'
     }
   ]
 });