Skip to content

Commit 213b0d5

Browse files
committed
clarify no-module-extensions message
1 parent 147b96b commit 213b0d5

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

lib/rules/no-module-extensions.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ module.exports = {
2121
meta: {
2222
type: 'problem',
2323
messages: {
24-
invalidModuleExtension: 'Module name should not include file extension \'{{ module }}\''
24+
invalidModuleExtension: 'Module name should not include file extension'
2525
},
26-
fixable: true
26+
fixable: 'code'
2727
},
2828

2929
create: function(context) {
@@ -39,9 +39,6 @@ module.exports = {
3939
context.report({
4040
node: invalidModuleNode,
4141
messageId: 'invalidModuleExtension',
42-
data: {
43-
module: invalidModuleNode.value
44-
},
4542
fix: function(fixer) {
4643
const fixedModuleName = invalidModuleNode.raw.replace(INVALID_MODULE_REGEX, '');
4744
return fixer.replaceText(invalidModuleNode, fixedModuleName);

tests/rules/no-module-extensions.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,22 @@ ruleTester.run('no-module-extensions', rule, {
4141
invalid: [
4242
{
4343
code: 'define(["./lib.js"], function(lib) {});',
44-
errors: [{ messageId: 'invalidModuleExtension', data: { module: './lib.js' }}],
44+
errors: [{ messageId: 'invalidModuleExtension' }],
4545
output: 'define(["./lib"], function(lib) {});'
4646
},
4747
{
4848
code: 'define([\'./lib.js\'], function(lib) {});',
49-
errors: [{ messageId: 'invalidModuleExtension', data: { module: './lib.js' }}],
49+
errors: [{ messageId: 'invalidModuleExtension' }],
5050
output: 'define([\'./lib\'], function(lib) {});'
5151
},
5252
{
5353
code: 'define(["./lib1", "./lib2.js"], function(lib1, lib2) {});',
54-
errors: [{ messageId: 'invalidModuleExtension', data: { module: './lib2.js' }}],
54+
errors: [{ messageId: 'invalidModuleExtension' }],
5555
output: 'define(["./lib1", "./lib2"], function(lib1, lib2) {});'
5656
},
5757
{
5858
code: 'define(["./lib1", "./lib2.js"], (lib1, lib2) => {});',
59-
errors: [{ messageId: 'invalidModuleExtension', data: { module: './lib2.js' }}],
59+
errors: [{ messageId: 'invalidModuleExtension' }],
6060
output: 'define(["./lib1", "./lib2"], (lib1, lib2) => {});'
6161
}
6262
]

0 commit comments

Comments
 (0)