refactor: propType locations

Author: Sven

src/components/Loading.jsx

@@ -2,6 +2,12 @@ import React from 'react'
 import { bool } from 'prop-types'
 import Spinner from 'react-spinkit'
 
+const propTypes = {
+  isLoading: bool,
+  timedOut: bool,
+  pastDelay: bool,
+  error: bool
+}
 function Loading(props) {
   if (props.isLoading) {
     // While our other component is loading...
@@ -24,11 +30,6 @@ function Loading(props) {
   }
 }
 
-Loading.propTypes = {
-  isLoading: bool,
-  timedOut: bool,
-  pastDelay: bool,
-  error: bool
-}
+Loading.propTypes = propTypes
 
 export default Loading

src/components/PrivateRoute.jsx

@@ -3,6 +3,12 @@ import PropTypes from 'prop-types'
 import { Route, Redirect } from 'react-router-dom'
 import { connect } from 'react-redux'
 
+const propTypes = {
+  isAuthenticated: PropTypes.bool.isRequired,
+  component: PropTypes.func.isRequired,
+  location: PropTypes.object.isRequired,
+}
+
 function PrivateRoute({ component: Component, isAuthenticated, ...rest }) {
   return (
     <Route {...rest} render={props => (
@@ -21,11 +27,7 @@ function PrivateRoute({ component: Component, isAuthenticated, ...rest }) {
   )
 }
 
-PrivateRoute.propTypes = {
-  isAuthenticated: PropTypes.bool.isRequired,
-  component: PropTypes.func.isRequired,
-  location: PropTypes.object.isRequired,
-}
+PrivateRoute.propTypes = propTypes
 
 const mapStateToProps = (state) => ({
   isAuthenticated: state.isAuthenticated

src/routes/Counter/components/Counter.jsx

@@ -4,6 +4,12 @@ import { Button } from 'reactstrap'
 
 // Stateless Functional Component
 // React style：https://github.com/airbnb/javascript/tree/master/react
+const propTypes = {
+  counter: number.isRequired,
+  increment: func.isRequired,
+  doubleAsync: func.isRequired
+}
+
 function Counter({ counter, increment, doubleAsync }) {
   return (<div style={{ margin: '0 auto' }}>
     <h3>Counter: {counter}</h3>
@@ -17,10 +23,6 @@ function Counter({ counter, increment, doubleAsync }) {
   </div>)
 }
 
-Counter.propTypes = {
-  counter: number.isRequired,
-  increment: func.isRequired,
-  doubleAsync: func.isRequired
-}
+Counter.propTypes = propTypes
 
 export default Counter

src/routes/Login/components/Login.jsx

@@ -3,6 +3,14 @@ import PropTypes from 'prop-types'
 import { Redirect } from 'react-router-dom'
 import { Button, Container } from 'reactstrap'
 
+const propTypes = {
+  authenticateWithCb: PropTypes.func.isRequired,
+  location: PropTypes.shape({
+    state: PropTypes.object,
+  }).isRequired,
+  isAuthenticated: PropTypes.bool.isRequired,
+}
+
 function Login({ location, isAuthenticated, authenticateWithCb }) {
   const { from } = location.state || { from: { pathname: '/' } }
   return isAuthenticated ? <Redirect to={from} />
@@ -13,12 +21,6 @@ function Login({ location, isAuthenticated, authenticateWithCb }) {
       </Container>
     )
 }
-Login.propTypes = {
-  authenticateWithCb: PropTypes.func.isRequired,
-  location: PropTypes.shape({
-    state: PropTypes.object,
-  }).isRequired,
-  isAuthenticated: PropTypes.bool.isRequired,
-}
+Login.propTypes = propTypes
 
 export default Login

src/routes/PageNotFound/components/PageNotFound.jsx

@@ -5,6 +5,10 @@ import './PageNotFound.scss'
 import { withRouter } from 'react-router'
 import { Button } from 'reactstrap'
 
+const propTypes = {
+  history: object.isRequired,
+}
+
 function PageNotFound({ history: { goBack } }) {
   return (<div className="not-found__container">
     <p>Page not found!!!</p>
@@ -24,8 +28,6 @@ function PageNotFound({ history: { goBack } }) {
   </div>)
 }
 
-PageNotFound.propTypes = {
-  history: object.isRequired,
-}
+PageNotFound.propTypes = propTypes
 
 export default withRouter(PageNotFound)

src/routes/Zen/components/Zen.jsx

@@ -3,6 +3,15 @@ import PropTypes from 'prop-types'
 import Spinner from 'react-spinkit'
 import { Button } from 'reactstrap'
 
+const propTypes = {
+  fetchZen: PropTypes.func.isRequired,
+  clearZen: PropTypes.func.isRequired,
+  zen: PropTypes.shape({
+    fetching: PropTypes.bool.isRequired,
+    text: PropTypes.array,
+  }).isRequired,
+}
+
 function Zen({ fetchZen, clearZen, zen: { fetching, text } }) {
   return (
     <div>
@@ -23,13 +32,6 @@ function Zen({ fetchZen, clearZen, zen: { fetching, text } }) {
     </div>)
 }
 
-Zen.propTypes = {
-  fetchZen: PropTypes.func.isRequired,
-  clearZen: PropTypes.func.isRequired,
-  zen: PropTypes.shape({
-    fetching: PropTypes.bool.isRequired,
-    text: PropTypes.array,
-  }).isRequired,
-}
+Zen.propTypes = propTypes
 
 export default Zen