Cleanup codes. Level 5

Author: Yousha

tests/SmokeTest.php

@@ -97,7 +97,7 @@ public function testLinterInstanceIsObject(): void
          *
          * @return void
          */
-        public function testCliInclusion()
+        public function testCliInclusion(): void
         {
             try {
                 $argv = ['--help'];

tests/Unit/Exceptions/LinterExceptionTest.php

@@ -21,7 +21,7 @@ final class LinterExceptionTest extends TestCase
      *
      * @return void
      */
-    public function testBasicException()
+    public function testBasicException(): void
     {
         $exception = new LinterException('Test message', 123);
         $this->assertEquals('Test message', $exception->getMessage());
@@ -37,7 +37,7 @@ public function testBasicException()
      *
      * @return void
      */
-    public function testExceptionWithContext()
+    public function testExceptionWithContext(): void
     {
         $exception = new LinterException('Test message', 0, null, 'Additional context');
         $this->assertEquals('Additional context', $exception->getContext());
@@ -52,7 +52,7 @@ public function testExceptionWithContext()
      *
      * @return void
      */
-    public function testFileAccessErrorFactory()
+    public function testFileAccessErrorFactory(): void
     {
         $exception = LinterException::fileAccessError('/path/to/file.php');
         $this->assertEquals(
@@ -74,7 +74,7 @@ public function testFileAccessErrorFactory()
      *
      * @return void
      */
-    public function testParsingErrorFactory()
+    public function testParsingErrorFactory(): void
     {
         $exception = LinterException::parsingError('/path/to/file.php', 'Syntax error');
         $this->assertEquals(
@@ -96,7 +96,7 @@ public function testParsingErrorFactory()
      *
      * @return void
      */
-    public function testInvalidRuleFactory()
+    public function testInvalidRuleFactory(): void
     {
         $exception = LinterException::invalidRule('bad_rule_pattern');
         $this->assertEquals(
@@ -118,7 +118,7 @@ public function testInvalidRuleFactory()
      *
      * @return void
      */
-    public function testExceptionChaining()
+    public function testExceptionChaining(): void
     {
         $previous = new \RuntimeException('Previous error');
         $exception = new LinterException('Wrapper error', 0, $previous);

tests/Unit/LinterTest.php

@@ -71,7 +71,7 @@ protected function tearDown(): void
      *
      * @return void
      */
-    public function testClassIsFinal()
+    public function testClassIsFinal(): void
     {
         $reflection = new \ReflectionClass(Linter::class);
         $this->assertTrue($reflection->isFinal(), 'Linter class should be final');
@@ -84,7 +84,7 @@ public function testClassIsFinal()
      *
      * @return void
      */
-    public function testClassHasCorrectNamespace()
+    public function testClassHasCorrectNamespace(): void
     {
         $this->assertStringStartsWith(
             'Yousha\PhpSecurityLinter',
@@ -100,7 +100,7 @@ public function testClassHasCorrectNamespace()
      *
      * @return void
      */
-    public function testLinterInitializesWithRules()
+    public function testLinterInitializesWithRules(): void
     {
         $reflection = new \ReflectionClass(Linter::class);
         $property = $reflection->getProperty('rules');
@@ -121,7 +121,7 @@ public function testLinterInitializesWithRules()
      *
      * @return void
      */
-    public function testScanMethodExists()
+    public function testScanMethodExists(): void
     {
         $this->assertTrue(
             method_exists(Linter::class, 'scan')
@@ -135,7 +135,7 @@ public function testScanMethodExists()
      *
      * @return void
      */
-    public function testScanMethodSignature()
+    public function testScanMethodSignature(): void
     {
         $method = new \ReflectionMethod(Linter::class, 'scan');
 
@@ -163,7 +163,7 @@ public function testScanMethodSignature()
      *
      * @return void
      */
-    public function testScanDirectoryWithNonPhpFiles()
+    public function testScanDirectoryWithNonPhpFiles(): void
     {
         $tempDir = sys_get_temp_dir() . '/test_dir_' . uniqid();
         mkdir($tempDir);
@@ -185,7 +185,7 @@ public function testScanDirectoryWithNonPhpFiles()
      *
      * @return void
      */
-    public function testScanReturnsMetadataWithFiles()
+    public function testScanReturnsMetadataWithFiles(): void
     {
         // Create temp dir with sample PHP file
         $tempDir = sys_get_temp_dir() . '/test_dir_' . uniqid();
@@ -209,7 +209,7 @@ public function testScanReturnsMetadataWithFiles()
      *
      * @return void
      */
-    public function testScanThrowsExceptionForInvalidPath()
+    public function testScanThrowsExceptionForInvalidPath(): void
     {
         $this->expectException(LinterException::class);
         $this->expectExceptionMessage('Path does not exist: /nonexistent/path');
@@ -224,7 +224,7 @@ public function testScanThrowsExceptionForInvalidPath()
      *
      * @return void
      */
-    public function testCanScanEmptyDirectory()
+    public function testCanScanEmptyDirectory(): void
     {
         $tempDir = sys_get_temp_dir() . '/empty_test_dir_' . uniqid();
         mkdir($tempDir);
@@ -253,7 +253,7 @@ public function testCanScanEmptyDirectory()
      *
      * @return void
      */
-    public function testShouldExcludeMethodIsPrivate()
+    public function testShouldExcludeMethodIsPrivate(): void
     {
         $method = new \ReflectionMethod(Linter::class, 'shouldExclude');
         $this->assertTrue($method->isPrivate());
@@ -266,7 +266,7 @@ public function testShouldExcludeMethodIsPrivate()
      *
      * @return void
      */
-    public function testScanFileMethodIsPrivate()
+    public function testScanFileMethodIsPrivate(): void
     {
         $method = new \ReflectionMethod(Linter::class, 'scanFile');
         $this->assertTrue($method->isPrivate());
@@ -279,7 +279,7 @@ public function testScanFileMethodIsPrivate()
      *
      * @return void
      */
-    public function testInvalidDirectory()
+    public function testInvalidDirectory(): void
     {
         $this->expectException(LinterException::class);
         $linter = new Linter();