Skip to content

Commit a2cfcb2

Browse files
amarantha-kmDuo13
andauthored
Apply suggestions from code review
Co-authored-by: Rome Reginelli <rome@ripple.com>
1 parent 2b8673c commit a2cfcb2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/concepts/tokens/decentralized-exchange/permissioned-dexes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ In summary, see the following table summarizing what offers can match:
7171
| Hybrid ||| ✅ (same domain) ||
7272
| Permissioned ||| ✅ (same domain) ||
7373

74-
There is no single ledger entry to represent a given permissioned DEX: it implicitly exists as all the order books with the same domain ID. Order books with a given domain ID are implicitly created when valid offers are placed using that domain ID, and those order books are automatically deleted when they are empty.
74+
There is no single ledger entry to represent a given permissioned DEX: it implicitly exists as all the order books with the same domain ID. Order books with a given domain ID are created when valid offers are placed using that domain ID, and those order books are automatically deleted when they are empty.
7575

7676
A single transaction can use multiple order books with the same domain ID—in other words, different currency pairs in the same permissioned DEX—either as part of a longer [cross-currency payment](../../payment-types/cross-currency-payments.md) or through auto-bridging. A hybrid offer can match a mix of permissioned and open offers, but a transaction cannot use multiple different domains.
7777

@@ -98,15 +98,15 @@ Like with unfunded offers, it is possible for an offer to become temporarily inv
9898

9999
The permissioned DEXes feature is enabled by the **PermissionedDEX** amendment, and relies on the [Credentials](../../decentralized-storage/credentials.md) and [Permissioned Domains](./permissioned-domains.md) amendments, so it cannot be used until _all_ of those amendments have been enabled.
100100

101-
**Not Compatible with AMMs**
101+
#### Not Compatible with AMMs
102102

103103
Permissioned DEXes are incompatible with [Automated Market Makers (AMMs)](../../tokens/decentralized-exchange/automated-market-makers.md). Permissioned offers and permissioned payments cannot be filled by AMMs, and access to AMMs cannot be restricted by a permissioned domain. Trades that use the open DEX can sometimes consume a hybrid offer and use an AMM in the same transaction, but transactions that specify a domain cannot use any AMMs.
104104

105105
**Permissioned DEXes are independent**
106106

107107
Each permissioned DEX is separate, with its own order books and offers. A single transaction cannot trade in multiple permissioned DEXes or aggregate liquidity from multiple permissioned DEXes. Hybrid offers can use a mix of one permissioned DEX and the open DEX, but they cannot use multiple different permissioned DEXes.
108108

109-
**Security Credential Consideration**
109+
#### Security Considerations for Permissioned DEXes
110110

111111
The security and fairness of a permissioned DEX depend on the owner of the permissioned domain and the issuers of credentials that grant access to it. At a baseline, the definition of each credential and the requirements for getting that credential are defined and enforced by the credential issuer, so the existence of a permissioned domain does not inherently mean anything about who is able to use it in practice.
112112

docs/concepts/tokens/fungible-tokens/multi-purpose-tokens.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ status: not_enabled
1111

1212
_(Requires the [MPTokensV1 amendment][] {% not-enabled /%})_
1313

14-
Multi-purpose tokens (MPTs) are a more compact and flexible type of [fungible token](/docs/concepts/tokens/fungible-tokens) on the XRP Ledger.
14+
Multi-purpose tokens (MPTs) are a more compact and flexible type of [fungible token](./index.md) on the XRP Ledger.
1515

1616
MPTs let you take advantage of ready-to-use tokenization features with a few lines of code. You can create many token experiences from one token program itself.
1717

0 commit comments

Comments
 (0)