Skip to content

Conversation

@jimmywan
Copy link

As discovered in the Georgia-Reborn Thene, sorting under "View By Folder Structure" breaks if track titles have a numeric prefix. As far as I can tell, the file names are already returned by the file system in sorted order, so we can avoid doing additional sorting when folder structure view is enabled.

Fix taken from TT-ReBORN/Georgia-ReBORN#204

@jimmywan jimmywan force-pushed the jw.fix_view_by_folder_structure_sort branch from 4a21321 to 8ddbdec Compare May 1, 2025 16:46
@TT-ReBORN
Copy link

TT-ReBORN commented May 26, 2025

Actually the "View By Folder Structure" view must be sorted and the proper fix is here:
TT-ReBORN/Georgia-ReBORN@8192840

-TT

@TT-ReBORN
Copy link

@regorxxx,

actually the current logic for "View By Folder" sorting is still wrong as it does not sort the album level like original
Windows Explorer natural sorting. A user has reported to me about this one week ago and I fixed it. Now it is correct for all
directory levels.

Here is the correct fix for natural Windows Explorer sorting:
TT-ReBORN/Georgia-ReBORN@8192840

I have updated the commit to the correct fix, you can update your original Library code as I fixed it already one week ago
in Georgia-ReBORN...

@regorxxx
Copy link

First time notifications works as intended hahaha Thanks for the heads up

regorxxx added a commit to regorxxx/Library-Tree-SMP that referenced this pull request Nov 21, 2025
	- Fix sorting under View By Folder Structure by jimmywan Wil-B#3
	- Changed how built-in icons paths are handled, using relative paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants