CoupledDofsRestriction: allow multiple matrices, reduce cols if redundant
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaap
force-pushed
the
feature/multi-coupling
branch
from
ad1f1a1 to
3350966
Compare
Member
Author
|
@chmerdon question here: Should we do the QR-truncation only for more than one given matrix? QR itself is pretty fast and is therefore no performance bottleneck. |
Member
|
maybe we can make a kwarg that is false for one matrix and true for more than one matrix, but that the user can override in case he wants his matrix to be reduced. |
pjaap
force-pushed
the
feature/multi-coupling
branch
from
3350966 to
83bc1af
Compare
Member
Author
|
Rebased and added the flag |
Member
Author
|
Ready from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.