Skip to content

Commit 520f669

Browse files
committed
More changelog detail
1 parent a494f6d commit 520f669

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

docs/changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
### Changed
1010

11+
* Files are now downloaded into the appropriate subdirectory. For example if you upload `parent/child.txt`, and then later download that file, the `parent` subdirectory will be created.
12+
* `FileSenderClient.download_file` now has some additional args: `file_size` and `file_name` which will enable better functionality if provided. They are typically obtained from `FileSenderClient._files_from_token`
1113
* All terminal output is now through the `logging` module. You can use the new `--log-level` CLI parameter to configure the amount of info that is printed out.
1214
* Update the CLI default concurrency to 2 for chunks and 1 for files. This seems to be moderately performant without ever failing
1315

filesender/api.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,6 @@ async def download_files(
343343
"""
344344
Downloads all files for a transfer.
345345
346-
Note that currently the directory hierarchy won't be preserved. So if the original user uploaded `dir_a/file_a.txt` and `dir_b/file_b.txt`, they will simply be downloaded as `file_a.txt` and `file_b.txt` with their directories stripped out. This is a limitation of the current API. See https://github.com/filesender/filesender/issues/1555 for context.
347-
348346
Params:
349347
token: Obtained from the transfer email. The same as [`GuestAuth`][filesender.GuestAuth]'s `guest_token`.
350348
out_dir: The path to write the downloaded files.

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ dev = [
4848
"pandas",
4949
"jupyter",
5050
"notebook<7",
51-
"nbconvert"
51+
"nbconvert",
52+
"jupyter_contrib_nbextensions"
5253
]
5354

5455
[project.scripts]

0 commit comments

Comments
 (0)