adding minor changes

Author: akumar91

recipes/perl/api_requests_rbac_policy.pl

@@ -123,7 +123,7 @@ sub delete_rbac_access_rule {
     $req->header('Authorization' => $token);
 
     print "\n\n**************************************************************";
-    print "\n\n Making DELETE Request to remove the object group \n\n";
+    print "\n\n Making DELETE Request to remove the access rule \n\n";
 
     my $resp = $ua->request($req);
     if ($resp->is_success) {
@@ -148,11 +148,13 @@ sub create_bpnbat_user {
 
     if ( $^O =~ /MSWin32/ ) {
         my $path = 'C:/\"Program Files\"/Veritas/NetBackup/bin/bpnbat.exe';
-        my $rc = system(qq($path -AddUser $username $domainName $password)); # returns exit status values
+        my $cmd = qq($path -AddUser $username $password $domainName);
+        my $rc = system($cmd); # returns exit status values
         die "system() failed with status $rc" unless $rc == 0;
     } else {
         my $path = '/usr/openv/netbackup/bin/bpnbat';
-        my $rc = system(qq($path -AddUser $username $domainName $password)); # returns exit status values
+        my $cmd = qq($path -AddUser $username $password $domainName);
+        my $rc = system($cmd); # returns exit status values
         die "system() failed with status $rc" unless $rc == 0;
     }
     print "\n\n";

recipes/perl/rbac_filtering_in_policy.pl

@@ -78,20 +78,22 @@ sub user_input {
 sub policy_rbac_automation {
     # perform login using user defined user and use the token for subsequent operations
     $token = perform_login($base_url, $username, $password, $domainName, $domainType);
+
     create_rbac_object_group_for_VMware_policy($base_url, $token);
+    # -------------------------------------------------------------- #
+    #  Create a new rbac user locally using bpnbat to assign object
+    #  level permissions to the newly created user and perform
+    #  subsequent operations.
+    # -------------------------------------------------------------- #
+    create_bpnbat_user($new_rbac_user, $new_rbac_domain, $new_rbac_pass);
     create_rbac_access_rules($base_url, $token, $new_rbac_user, $new_rbac_domain, $new_rbac_domainType);
+
     create_vmware_policy_with_defaults($base_url, $token);
     create_oracle_policy_with_defaults($base_url, $token);
 
     # list policies should display both oracle and vmware policy for admin user
     list_policies();
 
-    # -------------------------------------------------------------- #
-    #  Create a new rbac user locally using bpnbat to assign object
-    #  level permissions to the newly created user and perform
-    #  subsequent operations.
-    # -------------------------------------------------------------- #
-    create_bpnbat_user($new_rbac_user, $new_rbac_domain, $new_rbac_pass);
 
     my $new_rbac_user_token = perform_login($base_url, $new_rbac_user, $new_rbac_pass, $new_rbac_domain, $new_rbac_domainType);