Skip to content

Commit dec8065

Browse files
committed
Optional displaying vllm args, env vars, and bind paths, merge bind paths from cli arg with config instead of overwrite
1 parent 5cb84df commit dec8065

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

vec_inf/cli/_helper.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,22 +85,25 @@ def format_table_output(self) -> Table:
8585
table.add_row("Log Directory", self.params["log_dir"])
8686

8787
# Add vLLM configuration details
88-
table.add_row("vLLM Arguments:", style="magenta")
89-
for arg, value in self.params["vllm_args"].items():
90-
table.add_row(f" {arg}:", str(value))
88+
if self.params.get("vllm_args"):
89+
table.add_row("vLLM Arguments:", style="magenta")
90+
for arg, value in self.params["vllm_args"].items():
91+
table.add_row(f" {arg}:", str(value))
9192

9293
# Add environment variable configuration details
93-
table.add_row("Environment Variables", style="magenta")
94-
for arg, value in self.params["env"].items():
95-
table.add_row(f" {arg}:", str(value))
94+
if self.params.get("env"):
95+
table.add_row("Environment Variables", style="magenta")
96+
for arg, value in self.params["env"].items():
97+
table.add_row(f" {arg}:", str(value))
9698

9799
# Add bind path configuration details
98-
table.add_row("Bind Paths", style="magenta")
99-
for path in self.params["bind"].split(","):
100-
host = target = path
101-
if ":" in path:
102-
host, target = path.split(":")
103-
table.add_row(f" {host}:", target)
100+
if self.params.get("bind"):
101+
table.add_row("Bind Paths", style="magenta")
102+
for path in self.params["bind"].split(","):
103+
host = target = path
104+
if ":" in path:
105+
host, target = path.split(":")
106+
table.add_row(f" {host}:", target)
104107

105108
return table
106109

vec_inf/client/_helper.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,10 @@ def _get_launch_params(self) -> dict[str, Any]:
225225
params["env"][key] = str(value)
226226
del self.kwargs["env"]
227227

228+
if self.kwargs.get("bind") and params.get("bind"):
229+
params["bind"] = f"{params['bind']},{self.kwargs['bind']}"
230+
del self.kwargs["bind"]
231+
228232
for key, value in self.kwargs.items():
229233
params[key] = value
230234

0 commit comments

Comments
 (0)