Skip to content

Commit d950d06

Browse files
committed
Add default for bind, nodelist, exclude, and venv
1 parent d38122a commit d950d06

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

vec_inf/client/config.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,17 +125,20 @@ class ModelConfig(BaseModel):
125125
description="Resource type",
126126
)
127127
exclude: Optional[str] = Field(
128-
default=None,
128+
default=DEFAULT_ARGS["exclude"],
129129
description="Exclude certain nodes from the resources granted to the job",
130130
)
131131
nodelist: Optional[str] = Field(
132-
default=None, description="Request a specific list of nodes for deployment"
132+
default=DEFAULT_ARGS["nodelist"],
133+
description="Request a specific list of nodes for deployment",
133134
)
134135
bind: Optional[str] = Field(
135-
default=None, description="Additional binds for the singularity container"
136+
default=DEFAULT_ARGS["bind"],
137+
description="Additional binds for the container",
136138
)
137139
venv: str = Field(
138-
default="singularity", description="Virtual environment/container system"
140+
default=DEFAULT_ARGS["venv"],
141+
description="Virtual environment/container system",
139142
)
140143
log_dir: Path = Field(
141144
default=Path(DEFAULT_ARGS["log_dir"]),

vec_inf/config/environment.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
paths:
22
image_path: "/model-weights/vec-inf-shared/vector-inference_latest.sif"
3-
vllm_nccl_so_path: "/vec-inf/nccl/libnccl.so.2.18.1"
43

54
containerization:
65
module_load_cmd: "module load apptainer"
@@ -23,6 +22,10 @@ default_args:
2322
qos: ""
2423
partition: ""
2524
resource_type: ""
25+
exclude: ""
26+
nodelist: ""
27+
bind: ""
28+
venv: "apptainer"
2629
data_type: "auto"
2730
log_dir: "~/.vec-inf-logs"
2831
model_weights_parent_dir: "/model-weights"

0 commit comments

Comments
 (0)