Skip to content

Commit 40742ad

Browse files
committed
Update tests for new changes
1 parent 35e9a84 commit 40742ad

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

tests/test_imports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ def test_imports(self):
2323
import vec_inf.client._helper
2424
import vec_inf.client._slurm_script_generator
2525
import vec_inf.client._slurm_templates
26+
import vec_inf.client._slurm_vars # noqa: F401
2627
import vec_inf.client._utils
2728
import vec_inf.client.api
2829
import vec_inf.client.config
2930
import vec_inf.client.models
30-
import vec_inf.client.slurm_vars # noqa: F401
3131

3232
except ImportError as e:
3333
pytest.fail(f"Import failed: {e}")

tests/vec_inf/client/test_utils.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,11 @@ def test_load_config_default_only():
151151

152152
def test_load_config_with_user_override(tmp_path, monkeypatch):
153153
"""Test user config overriding default values."""
154-
# Create user config with override and new model
155-
user_config = tmp_path / "user_config.yaml"
156-
user_config.write_text("""\
154+
# Create user config directory and file
155+
user_config_dir = tmp_path / "user_config_dir"
156+
user_config_dir.mkdir()
157+
user_config_file = user_config_dir / "models.yaml"
158+
user_config_file.write_text("""\
157159
models:
158160
c4ai-command-r-plus-08-2024:
159161
gpus_per_node: 8
@@ -168,7 +170,7 @@ def test_load_config_with_user_override(tmp_path, monkeypatch):
168170
""")
169171

170172
with monkeypatch.context() as m:
171-
m.setenv("VEC_INF_CONFIG", str(user_config))
173+
m.setenv("VEC_INF_CONFIG_DIR", str(user_config_dir))
172174
configs = load_config()
173175
config_map = {m.model_name: m for m in configs}
174176

@@ -188,8 +190,11 @@ def test_load_config_with_user_override(tmp_path, monkeypatch):
188190

189191
def test_load_config_invalid_user_model(tmp_path):
190192
"""Test validation of user-provided model configurations."""
191-
invalid_config = tmp_path / "bad_config.yaml"
192-
invalid_config.write_text("""\
193+
# Create user config directory and file
194+
invalid_config_dir = tmp_path / "bad_config_dir"
195+
invalid_config_dir.mkdir()
196+
invalid_config_file = invalid_config_dir / "models.yaml"
197+
invalid_config_file.write_text("""\
193198
models:
194199
invalid-model:
195200
model_family: ""
@@ -200,7 +205,7 @@ def test_load_config_invalid_user_model(tmp_path):
200205

201206
with (
202207
pytest.raises(ValueError) as excinfo,
203-
patch.dict(os.environ, {"VEC_INF_CONFIG": str(invalid_config)}),
208+
patch.dict(os.environ, {"VEC_INF_CONFIG_DIR": str(invalid_config_dir)}),
204209
):
205210
load_config()
206211

0 commit comments

Comments
 (0)