improve model validations

Author: ValterAndrei

app/models/post.rb

@@ -1,4 +1,4 @@
 class Post < ApplicationRecord
-  validates :title,       presence: true
-  validates :description, presence: true
+  validates :title,       presence: true, length: { minimum: 3, maximum: 255 }
+  validates :description, presence: true, length: { minimum: 10, maximum: 10000 }
 end

test/models/post_test.rb

@@ -6,8 +6,31 @@ class PostTest < ActiveSupport::TestCase
     assert_not post.save, "Saved the post without a title and description"
   end
 
-  test "should save post with title and description" do
-    post = Post.new(title: "Sample Title", description: "Sample Description")
-    assert post.save, "Could not save the post with a title and description"
+  test "should not save post with too short title" do
+    post = Post.new(title: "Hi", description: "This is a valid description with enough length")
+    assert_not post.save, "Saved the post with a too short title"
+  end
+
+  test "should not save post with too long title" do
+    post = Post.new(title: "a" * 256, description: "This is a valid description with enough length")
+    assert_not post.save, "Saved the post with a too long title"
+  end
+
+  test "should not save post with too short description" do
+    post = Post.new(title: "Valid Title", description: "Too short")
+    assert_not post.save, "Saved the post with a too short description"
+  end
+
+  test "should not save post with too long description" do
+    post = Post.new(title: "Valid Title", description: "a" * 10_001)
+    assert_not post.save, "Saved the post with a too long description"
+  end
+
+  test "should save post with valid title and description" do
+    post = Post.new(
+      title: "Sample Title",
+      description: "This is a valid description with enough characters."
+    )
+    assert post.save, "Could not save the post with valid title and description"
   end
 end

test/requests/posts_controller_test.rb

@@ -3,9 +3,9 @@
 class PostsControllerTest < ActionDispatch::IntegrationTest
   test "should get index and return posts ordered by created_at" do
     # Arrange: Cria posts com datas diferentes
-    post1 = Post.create!(title: "Primeiro Post", description: "Primeiro", created_at: 2.days.ago)
-    post2 = Post.create!(title: "Segundo Post", description: "Segundo", created_at: 1.day.ago)
-    post3 = Post.create!(title: "Terceiro Post", description: "Terceiro", created_at: Time.current)
+    post1 = Post.create!(title: "Primeiro Post", description: "Primeiro desc", created_at: 2.days.ago)
+    post2 = Post.create!(title: "Segundo Post", description: "Segundo desc", created_at: 1.day.ago)
+    post3 = Post.create!(title: "Terceiro Post", description: "Terceiro desc", created_at: Time.current)
 
     # Act: Faz a requisição
     get posts_path

test/test_helper.rb

@@ -1,5 +1,6 @@
 ENV["RAILS_ENV"] ||= "test"
 require_relative "../config/environment"
+require "minitest/mock"
 require "rails/test_help"
 
 module ActiveSupport

test/tools/posts/create_tool_test.rb

@@ -4,38 +4,38 @@ class Posts::CreateToolTest < ActiveSupport::TestCase
   test "should create post with valid attributes" do
     assert_difference "Post.count", 1 do
       response = Posts::CreateTool.call(
-        title: "New Post",
-        description: "New Description",
+        title: "New Post Title",
+        description: "This is a valid description with enough characters",
         server_context: {}
       )
 
       assert_includes response.content.first[:text], "Post criado com sucesso"
     end
 
     post = Post.last
-    assert_equal "New Post", post.title
-    assert_equal "New Description", post.description
+    assert_equal "New Post Title", post.title
+    assert_equal "This is a valid description with enough characters", post.description
   end
 
   test "should return post id and title on success" do
     response = Posts::CreateTool.call(
-      title: "Test Post",
-      description: "Test Description",
+      title: "Test Post Title",
+      description: "Test Description with minimum length",
       server_context: {}
     )
 
     text = response.content.first[:text]
     post = Post.last
 
     assert_includes text, "ID: #{post.id}"
-    assert_includes text, "Título: Test Post"
+    assert_includes text, "Título: Test Post Title"
   end
 
   test "should not create post without title" do
     assert_no_difference "Post.count" do
       response = Posts::CreateTool.call(
         title: "",
-        description: "Description",
+        description: "Valid description with enough characters",
         server_context: {}
       )
 
@@ -47,7 +47,7 @@ class Posts::CreateToolTest < ActiveSupport::TestCase
   test "should not create post without description" do
     assert_no_difference "Post.count" do
       response = Posts::CreateTool.call(
-        title: "Title",
+        title: "Valid Title",
         description: "",
         server_context: {}
       )
@@ -56,4 +56,129 @@ class Posts::CreateToolTest < ActiveSupport::TestCase
       assert_includes response.content.first[:text].downcase, "description"
     end
   end
+
+  test "should not create post with title too short" do
+    assert_no_difference "Post.count" do
+      response = Posts::CreateTool.call(
+        title: "Ab",
+        description: "Valid description with enough characters",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text].downcase, "title"
+    end
+  end
+
+  test "should not create post with title too long" do
+    long_title = "a" * 256
+
+    assert_no_difference "Post.count" do
+      response = Posts::CreateTool.call(
+        title: long_title,
+        description: "Valid description with enough characters",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text].downcase, "title"
+    end
+  end
+
+  test "should not create post with description too short" do
+    assert_no_difference "Post.count" do
+      response = Posts::CreateTool.call(
+        title: "Valid Title",
+        description: "Short",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text].downcase, "description"
+    end
+  end
+
+  test "should not create post with description too long" do
+    long_description = "a" * 10001
+
+    assert_no_difference "Post.count" do
+      response = Posts::CreateTool.call(
+        title: "Valid Title",
+        description: long_description,
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text].downcase, "description"
+    end
+  end
+
+  test "should create post with minimum valid length" do
+    assert_difference "Post.count", 1 do
+      response = Posts::CreateTool.call(
+        title: "ABC",
+        description: "1234567890",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Post criado com sucesso"
+    end
+  end
+
+  test "should create post with maximum valid length" do
+    max_title = "a" * 255
+    max_description = "a" * 10000
+
+    assert_difference "Post.count", 1 do
+      response = Posts::CreateTool.call(
+        title: max_title,
+        description: max_description,
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Post criado com sucesso"
+    end
+
+    post = Post.last
+    assert_equal 255, post.title.length
+    assert_equal 10000, post.description.length
+  end
+
+  test "should handle exception during post creation" do
+    Post.stub :new, ->(*_args, **_kwargs) { raise StandardError.new("Unexpected error") } do
+      response = Posts::CreateTool.call(
+        title: "Valid Title",
+        description: "Valid description with enough characters",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text], "Unexpected error"
+    end
+  end
+
+  test "should handle unexpected errors gracefully" do
+    Post.stub :new, ->(*) { raise StandardError.new("Unexpected error") } do
+      response = Posts::CreateTool.call(
+        title: "Valid Title",
+        description: "Valid description with enough characters",
+        server_context: {}
+      )
+
+      assert_includes response.content.first[:text], "Erro ao criar post"
+      assert_includes response.content.first[:text], "Unexpected error"
+    end
+  end
+
+  test "should trim whitespace from title and description" do
+    Posts::CreateTool.call(
+      title: "  Valid Title  ",
+      description: "  Valid description with enough characters  ",
+      server_context: {}
+    )
+
+    post = Post.last
+    assert_equal "  Valid Title  ", post.title
+    assert_equal "  Valid description with enough characters  ", post.description
+  end
 end

test/tools/posts/index_tool_test.rb

@@ -100,7 +100,7 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should apply offset for pagination" do
-    5.times.map { |i| Post.create!(title: "Post #{i}", description: "Desc #{i}") }
+    5.times.map { |i| Post.create!(title: "Post #{i} 123", description: "Desc #{i} teste") }
 
     response = Posts::IndexTool.call(offset: 2, limit: 2, server_context: {})
 
@@ -124,7 +124,7 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should use default limit of 20" do
-    25.times { |i| Post.create!(title: "Post #{i}", description: "Desc #{i}") }
+    25.times { |i| Post.create!(title: "Post #{i} 123", description: "Desc #{i} teste") }
 
     response = Posts::IndexTool.call(server_context: {})
 
@@ -151,7 +151,7 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should handle search_term with special characters" do
-    Post.create!(title: "C++ Programming", description: "Learn C++")
+    Post.create!(title: "C++ Programming", description: "Desc Learn C++")
 
     response = Posts::IndexTool.call(search_term: "C++", server_context: {})
 
@@ -162,8 +162,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   # Testes de Ordenação
 
   test "should sort by created_at ascending" do
-    Post.create!(title: "Old Post", description: "Old", created_at: 2.days.ago)
-    Post.create!(title: "New Post", description: "New", created_at: 1.day.ago)
+    Post.create!(title: "Old Post", description: "Desc Post Old", created_at: 2.days.ago)
+    Post.create!(title: "New Post", description: "Desc Post New", created_at: 1.day.ago)
 
     response = Posts::IndexTool.call(sort_by: "created_at", sort_order: "asc", server_context: {})
 
@@ -175,8 +175,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should sort by created_at descending" do
-    Post.create!(title: "Old Post", description: "Old", created_at: 2.days.ago)
-    Post.create!(title: "New Post", description: "New", created_at: 1.day.ago)
+    Post.create!(title: "Old Post", description: "Desc Post Old", created_at: 2.days.ago)
+    Post.create!(title: "New Post", description: "Desc Post New", created_at: 1.day.ago)
 
     response = Posts::IndexTool.call(sort_by: "created_at", sort_order: "desc", server_context: {})
 
@@ -188,8 +188,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should sort by updated_at ascending" do
-    Post.create!(title: "First", description: "Desc", updated_at: 2.days.ago)
-    Post.create!(title: "Second", description: "Desc", updated_at: 1.day.ago)
+    Post.create!(title: "First Post", description: "Desc Post 123", updated_at: 2.days.ago)
+    Post.create!(title: "Second Post", description: "Desc Post 123", updated_at: 1.day.ago)
 
     response = Posts::IndexTool.call(sort_by: "updated_at", sort_order: "asc", server_context: {})
 
@@ -201,8 +201,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should sort by updated_at descending" do
-    Post.create!(title: "First", description: "Desc", updated_at: 2.days.ago)
-    Post.create!(title: "Second", description: "Desc", updated_at: 1.day.ago)
+    Post.create!(title: "First", description: "Desc first", updated_at: 2.days.ago)
+    Post.create!(title: "Second", description: "Desc second", updated_at: 1.day.ago)
 
     response = Posts::IndexTool.call(sort_by: "updated_at", sort_order: "desc", server_context: {})
 
@@ -246,9 +246,9 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should handle case-insensitive title sorting" do
-    Post.create!(title: "zebra", description: "Lowercase")
-    Post.create!(title: "Apple", description: "Capitalized")
-    Post.create!(title: "MONKEY", description: "Uppercase")
+    Post.create!(title: "zebra", description: "Lowercase 132")
+    Post.create!(title: "Apple", description: "Capitalized 123")
+    Post.create!(title: "MONKEY", description: "Uppercase 123")
 
     response = Posts::IndexTool.call(sort_by: "title", sort_order: "asc", server_context: {})
 
@@ -262,8 +262,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should use default sort_by when not specified" do
-    Post.create!(title: "Old", description: "Desc", created_at: 2.days.ago)
-    Post.create!(title: "New", description: "Desc", created_at: 1.day.ago)
+    Post.create!(title: "Old", description: "Desc 12345", created_at: 2.days.ago)
+    Post.create!(title: "New", description: "Desc 12345", created_at: 1.day.ago)
 
     response = Posts::IndexTool.call(server_context: {})
 
@@ -275,8 +275,8 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
   end
 
   test "should use default sort_order when not specified" do
-    Post.create!(title: "First", description: "Desc", created_at: 2.days.ago)
-    Post.create!(title: "Second", description: "Desc", created_at: 1.day.ago)
+    Post.create!(title: "First", description: "Desc 12345", created_at: 2.days.ago)
+    Post.create!(title: "Second", description: "Desc 12345", created_at: 1.day.ago)
 
     response = Posts::IndexTool.call(sort_by: "created_at", server_context: {})
 
@@ -333,9 +333,9 @@ class Posts::IndexToolTest < ActiveSupport::TestCase
 
   test "should handle sorting with identical timestamps" do
     timestamp = 1.day.ago
-    Post.create!(title: "Post A", description: "Desc A", created_at: timestamp)
-    Post.create!(title: "Post B", description: "Desc B", created_at: timestamp)
-    Post.create!(title: "Post C", description: "Desc C", created_at: timestamp)
+    Post.create!(title: "Post A", description: "Desc A 123", created_at: timestamp)
+    Post.create!(title: "Post B", description: "Desc B 123", created_at: timestamp)
+    Post.create!(title: "Post C", description: "Desc C 123", created_at: timestamp)
 
     response = Posts::IndexTool.call(sort_by: "created_at", sort_order: "desc", server_context: {})