You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed refreshing of Exp safety download button visibility by doing request polling of 3 times with delay of 2 seconds each, thereby avoid hard page refresh. Attached Video and Screenshot.
Motivation and Context
When an experiment safety review is approved, the download pdf button should be enabled. Since the status is computed through workflow, it takes some time. Currently, the browser needs to be refreshed to get the visibility of the button. However since this is an inconvenience, request polling has been implemented that fetches the new status and based on the new status, the button visibility is decided
How Has This Been Tested
Manually and attached e2e
Fixes
Avoiding Browser reload
Changes
In the Experiment Safety review summary page, the download button is placed. Instead of window reload, request polling using timeout has been implemented
In addition to the above, the menu has been slightly adjusted, where the experiment safety workflow has been moved next to the Proposal workflow
yoganandaness
changed the title
Swap 4928 user office experiment safety document disables
fix: user office experiment safety document disables
Oct 17, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yoganandaness
requested review from
bashanlam,
janosbabik and
simonfernandes
and removed request for
a team
simonfernandes
left a comment
Description
Fixed refreshing of Exp safety download button visibility by doing request polling of 3 times with delay of 2 seconds each, thereby avoid hard page refresh. Attached Video and Screenshot.
Motivation and Context
When an experiment safety review is approved, the download pdf button should be enabled. Since the status is computed through workflow, it takes some time. Currently, the browser needs to be refreshed to get the visibility of the button. However since this is an inconvenience, request polling has been implemented that fetches the new status and based on the new status, the button visibility is decided
How Has This Been Tested
Manually and attached e2e
Fixes
Avoiding Browser reload
Changes
In the Experiment Safety review summary page, the download button is placed. Instead of window reload, request polling using timeout has been implemented
In addition to the above, the menu has been slightly adjusted, where the experiment safety workflow has been moved next to the Proposal workflow
Depends on
Tests included/Docs Updated?