Skip to content

Commit 83e681f

Browse files
authored
SharePoint source connector: comment out permissions* settings (#233)
1 parent 9ff0642 commit 83e681f

File tree

5 files changed

+6
-17
lines changed

5 files changed

+6
-17
lines changed

snippets/general-shared-text/sharepoint-cli-api.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ The following environment variables:
1414
- `SHAREPOINT_APP_CLIENT_SECRET` - The client secret for the SharePoint application, represented by `--client-cred` (CLI) or `client_cred` (Python).
1515
- `SHAREPOINT_SITE` - The SharePoint site URL, represented by `--site` (CLI) or `site` (Python).
1616
- `SHAREPOINT_PATH` - The path in the SharePoint site from which to start parsing files, represented by `--path` (CLI) or `path` (Python).
17+
18+
{/*
1719
- `SHAREPOINT_APP_PERMISSIONS_CLIENT_ID` - The associated Azure application (client) ID, represented by `--permissions-application-id` (CLI) or `permissions_application_id` (Python).
1820
- `SHAREPOINT_APP_PERMISSIONS_CLIENT_SECRET` - The client secret for the Azure application, represented by `--permissions-client-cred` (CLI) or `permissions_client_cred` (Python).
1921
- `SHAREPOINT_APP_PERMISSIONS_TENANT` - The domian name of the tenant for the Azure application, which is typically `<organization-name>.onmicrosoft.com`, and which is represented by `--permissions-tenant` (CLI) or `permissions_tenant` (Python).
20-
22+
*/}

snippets/general-shared-text/sharepoint.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ The SharePoint prerequisites:
2121
allowfullscreen
2222
></iframe>
2323

24+
{/*
2425
- To process per-file access permissions, an associated Azure application (client) ID, along with its correpsonding directory (tenant) ID and client secret with access to the backing Azure account for SharePoint. [Get a client ID, tenant ID, and client secret, and set access permissions](https://tsmatz.wordpress.com/2016/10/07/application-permission-with-v2-endpoint-and-microsoft-graph/).
2526
2627
<iframe
@@ -31,4 +32,5 @@ The SharePoint prerequisites:
3132
frameborder="0"
3233
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
3334
allowfullscreen
34-
></iframe>
35+
></iframe>
36+
*/}

snippets/source_connectors/sharepoint.sh.mdx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@ unstructured-ingest \
77
--client-cred $SHAREPOINT_APP_CLIENT_SECRET \
88
--site $SHAREPOINT_SITE \
99
--path $SHAREPOINT_PATH \
10-
--permissions-application-id $SHAREPOINT_APP_PERMISSIONS_CLIENT_ID \
11-
--permissions-client-cred $SHAREPOINT_APP_PERMISSIONS_CLIENT_SECRET \
12-
--permissions-tenant $SHAREPOINT_APP_PERMISSIONS_TENANT \
13-
--permissions-authority-url https://login.microsoftonline.com \
1410
--no-omit-files \
1511
--omit-pages \
1612
--omit-lists \

snippets/source_connectors/sharepoint.v1.py.mdx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ if __name__ == "__main__":
2626
access_config=SharepointAccessConfig(
2727
client_cred=os.getenv("SHAREPOINT_APP_CLIENT_SECRET"),
2828
),
29-
permissions_config=SharepointPermissionsConfig(
30-
application_id=os.getenv("SHAREPOINT_APP_PERMISSIONS_CLIENT_ID"),
31-
client_cred=os.getenv("SHAREPOINT_APP_PERMISSIONS_CLIENT_SECRET"),
32-
tenant=os.getenv("SHAREPOINT_APP_PERMISSIONS_TENANT"),
33-
),
3429
client_id=os.getenv("SHAREPOINT_APP_CLIENT_ID"),
3530
site=os.getenv("SHAREPOINT_SITE"),
3631
files_only=True,

snippets/source_connectors/sharepoint.v2.py.mdx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ if __name__ == "__main__":
3939
access_config=SharepointAccessConfig(client_cred=os.getenv("SHAREPOINT_APP_CLIENT_SECRET")),
4040
client_id=os.getenv("SHAREPOINT_APP_CLIENT_ID"),
4141
site=os.getenv("SHAREPOINT_SITE"),
42-
permissions_config=SharepointPermissionsConfig(
43-
permissions_application_id=os.getenv("SHAREPOINT_APP_PERMISSIONS_CLIENT_ID"),
44-
permissions_tenant=os.getenv("SHAREPOINT_APP_PERMISSIONS_TENANT"),
45-
permissions_client_cred=os.getenv("SHAREPOINT_APP_PERMISSIONS_CLIENT_SECRET"),
46-
authority_url="https://login.microsoftonline.com"
47-
)
4842
),
4943
partitioner_config=PartitionerConfig(
5044
partition_by_api=True,

0 commit comments

Comments
 (0)