fix: resetting local user on profile change [MTT-11948] (#916)

* resetting local user on profile change

* cleanup

* formatting

Author: fernando-cortez

Assets/Scripts/Gameplay/GameState/ClientMainMenuState.cs

@@ -71,7 +71,7 @@ protected override void Configure(IContainerBuilder builder)
             builder.RegisterComponent(m_IPUIMediator);
         }
 
-        private async void TrySignIn()
+        async void TrySignIn()
         {
             try
             {
@@ -88,16 +88,21 @@ private async void TrySignIn()
             }
         }
 
-        private void OnAuthSignIn()
+        void OnAuthSignIn()
         {
             m_SessionButton.interactable = true;
             m_UGSSetupTooltipDetector.enabled = false;
             m_SignInSpinner.SetActive(false);
 
             Debug.Log($"Signed in. Unity Player ID {AuthenticationService.Instance.PlayerId}");
+
+            m_LocalUser.ID = AuthenticationService.Instance.PlayerId;
+
+            // The local SessionUser object will be hooked into UI before the LocalSession is populated during session join, so the LocalSession must know about it already when that happens.
+            m_LocalSession.AddUser(m_LocalUser);
         }
 
-        private void OnSignInFailed()
+        void OnSignInFailed()
         {
             if (m_SessionButton)
             {

Assets/Scripts/UnityServices/Sessions/LocalSession.cs

@@ -213,9 +213,10 @@ public void ApplyRemoteData(ISession session)
             CopyDataFrom(info, localSessionUsers);
         }
 
-        public void Reset()
+        public void Reset(LocalSessionUser localUser)
         {
             CopyDataFrom(new SessionData(), new Dictionary<string, LocalSessionUser>());
+            AddUser(localUser);
         }
     }
 }

Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs

@@ -227,7 +227,7 @@ void ResetSession()
         {
             CurrentUnitySession = null;
             m_LocalUser?.ResetState();
-            m_LocalSession?.Reset();
+            m_LocalSession?.Reset(m_LocalUser);
 
             // no need to disconnect Netcode, it should already be handled by Netcode's callback to disconnect
         }