Skip to content

Commit 8aa3c91

Browse files
committed
Changed clear to clear -x to retain CLI command history. Expanded report Title Descriptions. Added more stderr redirections on some commands.
1 parent b640d88 commit 8aa3c91

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

system-info

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function other_commands()
8181

8282
function CheckRoot()
8383
{
84-
clear;
84+
clear -x;
8585
## Check if ran as root. Runs at startup. Called by Main()
8686
if [[ "$EUID" == 0 ]]
8787
then
@@ -204,14 +204,14 @@ function CheckPrerequisites()
204204
do
205205
if [ $(type ${Program} > /dev/null 2>&1 ; echo $?) -ne 0 ]
206206
then
207-
echo -e " --- Some Programs Were Missing --- "
207+
echo -e " --- Some Programs This Script Uses Were Missing --- "
208208
if [[ "$Program" == "mokutil" ]]
209209
then # If not 'Here' condition
210210
# If this missing, it is a variant for UEFI systems only. It does work on 18.04 where it was not default yet, and is
211211
# a useful option to see if there "is" a SecureBoot option in the BIOS, besides just what it is set at. This, during
212212
# tests, is safe to install on Legacy Only BIOS systems and can be used to tell if the BIOS is such.
213213
echo -e "$faintvid \"${Program}\" could not be found. This program is suggested.$resetvid"
214-
echo -e "If this is older hardware that is 'Legacy Only BIOS', then this can be ignored."
214+
echo -e "$faintvid If this is older hardware that is 'Legacy Only BIOS', then this can be ignored."
215215
check_mokutil=0; # Set Flag to false and recheck in GetSb()
216216
check_prog=0;
217217
debug "$Program is not installed" 1
@@ -267,7 +267,7 @@ function UserInput()
267267
echo -e "Please provide some \"Basic Information\"..."
268268
read -p "What is the Main Complaint (summarized)? " main_complaint
269269
read -p "Describe the Problem: " problem_description
270-
clear
270+
clear -x
271271
}
272272

273273
function GetMachineInfo()
@@ -284,9 +284,9 @@ function GetMachineInfo()
284284
function GetCPU()
285285
{
286286
# Gets CPU Information. Called once by GetMachineInfo().
287-
echo -e "${setansi}---------- General computer specs:$ransi"
287+
echo -e "${setansi}---------- General Computer Specifications:$ransi"
288288
nl
289-
echo -e " --- Computer/CPU Information --- "
289+
echo -e " --- Computer/CPU Information from 'lshw -C cpu' --- "
290290
$lshw_cmd -C cpu \
291291
| sed -r '/^ *([a-z])/ s/([a-zA-Z])/\u&/' \
292292
| sed -e 's/^ *\*-cpu/\*-Cpu/g' \
@@ -324,7 +324,7 @@ function GetDmi()
324324
board_serial
325325
board_asset_tag'
326326

327-
echo -e "------------------ SMBIOS Information"
327+
echo -e "------------------ SMBIOS Information from '/sys/class/dmi/id/' "
328328

329329
if [ -d $smbios_compliant ]
330330
then
@@ -372,7 +372,7 @@ function GetSb()
372372
{
373373
# Gets SafeBoot Info from UEFI BIOS or if not UEFI capable. Called once by GetDMI().
374374
# Warns user if mokutil was not present.
375-
#echo -e " --- SecureBoot Status:"
375+
#echo -e " --- SecureBoot Status from 'mokutil --sb-state':"
376376
if [ $check_mokutil -eq 0 ]
377377
then
378378
echo -e "\tThis would check / have checked if SecureBoot was enabled or not, "
@@ -424,7 +424,7 @@ function GetMem()
424424
function GetUsb()
425425
{
426426
# Gets USB information. Called once by Writer().
427-
echo -e "${setansi}---------- USB Information:$ransi"
427+
echo -e "${setansi}---------- USB Information from 'lsusb -t -v':$ransi"
428428
usb_info=$(lsusb -t -v)
429429
echo -e "$usb_info"
430430
nl
@@ -439,7 +439,7 @@ function GetNetworkingInfo()
439439
then
440440
GetInternetStatus
441441
else
442-
echo -e " --- Internet Connection Status --- "
442+
echo -e " --- Internet Connection Status from 'ip addr' --- "
443443
echo -e "Skipped getting Internet Status. Connection: $up_status"
444444
nl
445445
fi
@@ -451,7 +451,7 @@ function GetInternetStatus()
451451
# Verifies ping status and relsolv. Called once by GetNetworkingInfo().
452452
ping -c 1 www.google.com > /dev/null
453453
pingStatus=$?
454-
echo -e " --- Internet Connection Status --- "
454+
echo -e " --- Internet Connection Status from 'ping [various addresses]' --- "
455455
if [ $pingStatus == 0 ]
456456
then
457457
echo -e "Connected to Internet with DNS"
@@ -486,7 +486,7 @@ function GetIP()
486486
{
487487
# Get IP related information. Called once by GetNetworkingInfo().
488488
echo -e "${setansi}---------- IP Adress Information:$ransi"
489-
echo -e " --- IP Adress Information --- "
489+
echo -e " --- IP Adress Information from 'ip addr' --- "
490490
# Grab IP adress information
491491
if [ "$less_status" == "less" ]
492492
then
@@ -508,7 +508,7 @@ function CheckIpUp()
508508
ip_devices_up=$(ip addr | grep -e '^[[:space:][1-9]:.*UP,LOWER_UP' | sed 's/.*virb.*:.*\|.*lo:.*LOOPBACK.*//g' | sed -e /^$/d)
509509
if [ "$show_silent" == "show" ]
510510
then
511-
echo -e " --- Network Device Status Summary --- "
511+
echo -e " --- Network Device Status Summary from 'ip addr' --- "
512512
if [ "$ip_devices_up" == "" ]
513513
then
514514
echo -e "No Network Devices up..."
@@ -536,7 +536,7 @@ function CheckIpUp()
536536
function GetFQDN()
537537
{
538538
# Gets Hostname information. Called once by GetMachineInfo().
539-
echo -e " --- Hostname --- "
539+
echo -e " --- Hostname from 'hostname --fqdn' --- "
540540
if [ "$less_status" == "less" ]
541541
then
542542
host_name=$(hostname --fqdn)
@@ -588,7 +588,7 @@ function GetGraphicsEnv()
588588
echo -e "$lshw_data"
589589
fi
590590
nl
591-
echo -e " --- Graphics Environment Continued ----"
591+
echo -e " --- Graphics Environment Continued form 'various graphics ENVs' ----"
592592
if [ $XDG_CURRENT_DESKTOP ]
593593
then
594594
echo -e "The Current Configured Destop is: $XDG_CURRENT_DESKTOP "
@@ -637,7 +637,7 @@ function GetGraphicsEnv()
637637
function GetRepositories()
638638
{
639639
# Gets Repository Information. Called once by Writer(). ** TODO Proposed
640-
echo -e "${setansi}---------- Repository Information:$ransi"
640+
echo -e "${setansi}---------- Repository Information from '/etc/apt/sources.list and etc/apt/sources.list.d/':$ransi"
641641
nl
642642
sources=$(grep -v '#' /etc/apt/sources.list | sed -e /^$/d )
643643
# sourcesd=$(grep -v '#' /etc/apt/sources.list.d/* | sed -e /^$/d)
@@ -669,7 +669,7 @@ function GetRepositories()
669669
function GetRepositoriesOld()
670670
{
671671
# Gets Repository Informations. Called once by Writer().
672-
echo -e "${setansi}---------- Repository Information:$ransi"
672+
echo -e "${setansi}---------- Repository Information from '/etc/apt/sources.list':$ransi"
673673
nl
674674
sources=$(grep -v '#' /etc/apt/sources.list | sed -e /^$/d )
675675
# sourcesd=$(grep -v '#' /etc/apt/sources.list.d/* | sed -e /^$/d)
@@ -689,7 +689,7 @@ function GetRepositoriesOld()
689689
function GetOtherDetails()
690690
{
691691
# Gets Other General Details. Gets called once by Writer().
692-
echo -e "${setansi}---------- Other Details:$ransi"
692+
echo -e "${setansi}---------- Other Details from 'Various':$ransi"
693693
echo -e "The current kernel version is: ${setansi} $(uname -r) $ransi"
694694
echo -e "The current release description is: ${setansi} $(lsb_release -sd) $ransi"
695695
GetOriginalInstallDate
@@ -712,13 +712,13 @@ function GetOriginalInstallDate()
712712
{
713713
# Gets the original installation date. Called once by GetOtherDetails().
714714
# Makes best logical efforts.
715-
if [ $(sudo find /var/log/installer/ -type f | wc -l) -ne 0 ]
715+
if [ $(sudo find /var/log/installer/ -type f 2> /dev/null | wc -l) -ne 0 ]
716716
then
717-
installer_date=$(sudo find /var/log/installer/ -type f -printf "%T+\n" | sort| head -1 2> /dev/null )
717+
installer_date=$(sudo find /var/log/installer/ -type f -printf "%T+\n" 2> /dev/null | sort| head -1 2> /dev/null )
718718
installer_date="Original Installation Date: ${setansi} ${installer_date%.*} $ransi"
719719
else
720-
debug "$(sudo find / -maxdepth 1 -type d -printf "%T+ %p\n"| sort| head -1 )" 1
721-
installer_date=$(sudo find / -maxdepth 1 -type d -printf "%T+ %p\n"| sort| head -1)
720+
debug "$(sudo find / -maxdepth 1 -type d -printf "%T+ %p\n" > /dev/null | sort| head -1 )" 1
721+
installer_date=$(sudo find / -maxdepth 1 -type d -printf "%T+ %p\n" 2> /dev/null | sort | head -1)
722722
installer_date="Estimated Installation Date: ${setansi} ${installer_date%.*} $ransi"
723723
fi
724724
echo -e "$installer_date"
@@ -753,10 +753,10 @@ function GetDistUpgradeDate()
753753
function GetHweKernels()
754754
{
755755
echo -e "These are the current kernel ranges for HWE kernels for this release."
756-
show_kernels=$(apt-cache show linux-generic-hwe-$(lsb_release -sr) \
756+
show_kernels=$(apt-cache show linux-generic-hwe-$(lsb_release -sr) 2> /dev/null \
757757
| awk '/Depends:/ {print "For HWE Package: " $2 ", Kernel Version: " $4}' \
758-
| sed -e 's/..$//' -e 's/~.*//')
759-
echo -e " --- HWE Kernel Reference:"
758+
| sed -e 's/..$//' -e 's/~.*//') 2> /dev/null
759+
echo -e " --- HWE Kernel Reference from 'apt-cache show':"
760760
echo -e "$show_kernels"
761761
nl
762762
}
@@ -765,7 +765,7 @@ function CheckHwe()
765765
{
766766
return_status=$(dpkg -s linux-generic-hwe-$(lsb_release -sr) 2>&1 \
767767
| grep 'Status\|dpkg-query' )
768-
echo -e " --- HWE Package Status:"
768+
echo -e " --- HWE Package Status from 'dpkg':"
769769
if [[ "$return_status" == *"Status:"* ]]
770770
then
771771
echo -e "Package linux-generic-hwe-$(lsb_release -sr) is installed."

0 commit comments

Comments
 (0)