Completed internal conversion of all handle interning caches to a common base type/interface pattern. (#40)

## Breaking Changes
BitcodeModule is no longer a "newable" type. Creating modules now requires calling factory methods on the context. This is a small but necessary change to clean up internal complexity and clarify the actual ownership via a factory method.

Author: smaillet

Samples/CodeGenWithDebugInfo/Program.cs

@@ -71,7 +71,7 @@ public static void Main( string[ ] args )
 
                 // <CreatingModule>
                 using( var context = new Context( ) )
-                using( var module = new BitcodeModule( context, moduleName ) )
+                using( var module = context.CreateBitcodeModule( moduleName ) )
                 {
                     module.SourceFileName = Path.GetFileName( srcPath );
                     module.TargetTriple = TargetDetails.TargetMachine.Triple;

Samples/Kaleidoscope/Chapter3/CodeGenerator.cs

@@ -23,7 +23,7 @@ internal sealed class CodeGenerator
         public CodeGenerator( LanguageLevel level )
         {
             Context = new Context( );
-            Module = new BitcodeModule( Context, "Kaleidoscope" );
+            Module = Context.CreateBitcodeModule( "Kaleidoscope" );
             InstructionBuilder = new InstructionBuilder( Context );
             NamedValues = new Dictionary<string, Value>( );
             ParserStack = new ReplParserStack( level );

Samples/Kaleidoscope/Chapter4/CodeGenerator.cs

@@ -167,7 +167,7 @@ public override Value VisitTopLevelExpression( [NotNull] TopLevelExpressionConte
 
         private void InitializeModuleAndPassManager( )
         {
-            Module = new BitcodeModule( Context );
+            Module = Context.CreateBitcodeModule( );
             FunctionPassManager = new FunctionPassManager( Module );
             FunctionPassManager.AddInstructionCombiningPass( )
                                .AddReassociatePass( )

Samples/Kaleidoscope/Chapter5/CodeGenerator.cs

@@ -339,7 +339,7 @@ public override Value VisitForExpression( [NotNull] ForExpressionContext context
 
         private void InitializeModuleAndPassManager( )
         {
-            Module = new BitcodeModule( Context, "Kaleidoscope" );
+            Module = Context.CreateBitcodeModule( "Kaleidoscope" );
             FunctionPassManager = new FunctionPassManager( Module );
             FunctionPassManager.AddInstructionCombiningPass( )
                                .AddReassociatePass( )

Samples/Kaleidoscope/Chapter6/CodeGenerator.cs

@@ -395,7 +395,7 @@ public override Value VisitForExpression( [NotNull] ForExpressionContext context
 
         private void InitializeModuleAndPassManager( )
         {
-            Module = new BitcodeModule( Context, "Kaleidoscope" );
+            Module = Context.CreateBitcodeModule( "Kaleidoscope" );
             FunctionPassManager = new FunctionPassManager( Module );
             FunctionPassManager.AddInstructionCombiningPass( )
                                .AddReassociatePass( )

Samples/Kaleidoscope/Chapter7/CodeGenerator.cs

@@ -453,7 +453,7 @@ public override Value VisitVarInExpression( [NotNull] VarInExpressionContext con
 
         private void InitializeModuleAndPassManager( )
         {
-            Module = new BitcodeModule( Context, "Kaleidoscope" );
+            Module = Context.CreateBitcodeModule( "Kaleidoscope" );
             FunctionPassManager = new FunctionPassManager( Module );
             FunctionPassManager.AddPromoteMemoryToRegisterPass()
                                .AddInstructionCombiningPass( )

Samples/Kaleidoscope/Chapter8/CodeGenerator.cs

@@ -443,7 +443,7 @@ public override Value VisitVarInExpression( [NotNull] VarInExpressionContext con
 
         private void InitializeModuleAndPassManager( )
         {
-            Module = new BitcodeModule( Context, "Kaleidoscope" );
+            Module = Context.CreateBitcodeModule( "Kaleidoscope" );
         }
 
         private Function GetFunction( string name )

Samples/Kaleidoscope/Chapter9/CodeGenerator.cs

@@ -33,11 +33,9 @@ public CodeGenerator( LanguageLevel level, TargetMachine machine )
             NamedValues = new Dictionary<string, Alloca>( );
             FunctionPrototypes = new PrototypeCollection( );
             ParserStack = new ReplParserStack( level );
-            Module = new BitcodeModule( Context, "Kaleidoscope", SourceLanguage.C, "fib.ks", "Kaleidoscope Compiler" )
-            {
-                TargetTriple = machine.Triple,
-                Layout = machine.TargetData
-            };
+            Module = Context.CreateBitcodeModule( "Kaleidoscope", SourceLanguage.C, "fib.ks", "Kaleidoscope Compiler" );
+            Module.TargetTriple = machine.Triple;
+            Module.Layout = machine.TargetData;
             DoubleType = new DebugBasicType( Context.DoubleType, Module, "double", DiTypeKind.Float );
         }
 

src/Llvm.NET.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.27128.1
+VisualStudioVersion = 15.0.27130.2003
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Llvm.NET", "Llvm.NET\Llvm.NET.csproj", "{0162C8CE-6641-4922-8664-F8A44356FBF7}"
 EndProject