Skip to content

Output of SQL updates for more StaticFlags related to unit_flags #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meji46 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Output of SQL updates for more StaticFlags related to unit_flags #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WowPacketParser/Enums/UnitFlags2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public enum UnitFlags2 : uint // 4.x
MirrorImage | ForceMovement | DisarmOffhand |
DisablePredStats | AllowChangingTalents | DisarmRanged |
/* RegeneratePower | */ RestrictPartyInteraction | CannotTurn |
PreventSpellClick | /* InteractWhileHostile | */ /* Unk2 | */
PreventSpellClick | InteractWhileHostile | /* Unk2 | */
/* PlayDeathAnim | */ AllowCheatSpells | SuppressHighlightWhenTargetedOrMousedOver |
TreatAsRaidUnitForHelpfulSpells | LargeAOI | GiganticAOI | NoActions |
AiWillOnlySwimIfTargetSwims | DontGenerateCombatLogWhenEngagedWithNpcs | AttackerIgnoresMinimumRanges |
Expand Down
2 changes: 1 addition & 1 deletion WowPacketParser/Enums/UnitFlags3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ public enum UnitFlags3 : uint // 7.x
Unk30 = 0x40000000,
Unk31 = 0x80000000,

Disallowed = (IgnoreCombat | FakeDead | AlreadySkinned | AllowInteractionWhileInCombat)
Disallowed = (AlternativeDefaultLanguage | IgnoreCombat | FakeDead | AlreadySkinned | AllowInteractionWhileInCombat)
}
}
45 changes: 38 additions & 7 deletions WowPacketParser/SQL/Builders/UnitMisc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,24 +160,55 @@ public static string CreatureTemplateScalingDataWDB()

public static void UpdateCreatureStaticFlags(ref Unit npc, ref CreatureTemplateDifficulty creatureDifficulty)
{
if ((npc.UnitData.Flags & (uint)UnitFlags.CanSwim) != 0)
if (npc.UnitData.Flags.HasAnyFlag(UnitFlags.CanSwim))
creatureDifficulty.StaticFlags1 |= CreatureStaticFlags.CanSwim;
if ((npc.UnitData.Flags & (uint)UnitFlags.CantSwim) != 0)
if (npc.UnitData.Flags.HasAnyFlag(UnitFlags.CantSwim))
creatureDifficulty.StaticFlags3 |= CreatureStaticFlags3.CannotSwim;

if ((npc.UnitData.Flags2 & (uint)UnitFlags2.CannotTurn) != 0)
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.HideBody))
creatureDifficulty.StaticFlags2 |= CreatureStaticFlags2.HideBody;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.InstantlyDontFadeIn))
creatureDifficulty.StaticFlags3 |= CreatureStaticFlags3.DoNotFadeIn;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.CannotTurn))
creatureDifficulty.StaticFlags3 |= CreatureStaticFlags3.CannotTurn;

if ((npc.UnitData.Flags3 & (uint)UnitFlags3.AllowInteractionWhileInCombat) != 0)
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.TreatAsRaidUnitForHelpfulSpells))
creatureDifficulty.StaticFlags4 |= CreatureStaticFlags4.TreatAsRaidUnitForHelpfulSpells;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.AttackerIgnoresMinimumRanges))
creatureDifficulty.StaticFlags4 |= CreatureStaticFlags4.IgnoreSpellMinRangeRestrictions;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.AiWillOnlySwimIfTargetSwims))
creatureDifficulty.StaticFlags4 |= CreatureStaticFlags4.PreventSwim;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.DontGenerateCombatLogWhenEngagedWithNpcs))
creatureDifficulty.StaticFlags4 |= CreatureStaticFlags4.HideInCombatLog;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.UntargetableByClient))
creatureDifficulty.StaticFlags5 |= CreatureStaticFlags5.UntargetableByClient;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.UninteractibleIfHostile))
creatureDifficulty.StaticFlags5 |= CreatureStaticFlags5.UninteractibleIfHostile;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.InteractWhileHostile))
creatureDifficulty.StaticFlags5 |= CreatureStaticFlags5.InteractWhileHostile;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.SuppressHighlightWhenTargetedOrMousedOver))
creatureDifficulty.StaticFlags5 |= CreatureStaticFlags5.SuppressHighlightWhenTargetedOrMousedOver;
if (npc.UnitData.Flags2.HasAnyFlag(UnitFlags2.RegeneratePower))
creatureDifficulty.StaticFlags1 &= ~CreatureStaticFlags.NoAutomaticRegen;

if (npc.UnitData.Flags3.HasAnyFlag(UnitFlags3.AllowInteractionWhileInCombat))
creatureDifficulty.StaticFlags3 |= CreatureStaticFlags3.AllowInteractionWhileInCombat;

// Not 100% reliable
// CreatureStaticFlags.ImmuneToPc - UnitFlags.ImmunePC
// CreatureStaticFlags.ImmuneToNpc - UnitFlags.ImmuneNPC
// CreatureStaticFlags.Uninteractible - UnitFlags.Uninteractible
if ((ClientVersion.Expansion == ClientType.WrathOfTheLichKing && npc.Movement.Flags.HasAnyFlag(MovementFlag.DisableGravity)) ||
(ClientVersion.Expansion >= ClientType.Cataclysm && npc.Movement.Flags.HasAnyFlag(Enums.v4.MovementFlag.DisableGravity)))
creatureDifficulty.StaticFlags1 |= CreatureStaticFlags.Floating; // Not 100% reliable
creatureDifficulty.StaticFlags1 |= CreatureStaticFlags.Floating;

if ((ClientVersion.Expansion == ClientType.WrathOfTheLichKing && npc.Movement.Flags.HasAnyFlag(MovementFlag.Root)) ||
(ClientVersion.Expansion >= ClientType.Cataclysm && npc.Movement.Flags.HasAnyFlag(Enums.v4.MovementFlag.Root)))
creatureDifficulty.StaticFlags1 |= CreatureStaticFlags.Sessile; // Not 100% reliable
creatureDifficulty.StaticFlags1 |= CreatureStaticFlags.Sessile;

// Handled by creature_template_addon.visibilityDistanceType
// CreatureStaticFlags.LargeAoi - UnitFlags2.LargeAOI
// CreatureStaticFlags3.GiganticAoi - UnitFlags2.GiganticAOI
// CreatureStaticFlags3.InfiniteAoi - UnitFlags2.InfiniteAOI
}

[BuilderMethod(true, Units = true)]
Expand Down