Skip to content

Pluginval silently succeeds when empty path given to --validate #143

@sudara

Description

@sudara

Noticed this in Release, in CI:

Arc - 2024-12-04 51@2x

In Debug, it hits an assert:

➜  cmake-build-debug git:(main) ✗ ./modules/pluginval/pluginval_artefacts/Debug/pluginval.app/Contents/MacOS/pluginval --strictness-level 10 --timeout-ms 110000 --verbose --validate ""          
JUCE v8.0.4
JUCE Assertion failure in PluginTests.cpp:53
Started validating: 
Random seed: 0x26a7379
Validation started
	4 Dec 2024 10:49:55pm

Strictness level: 10
SUCCESS

In addition to the assert, it should probably emit an error message and return exit code 1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions