Enhanced skip ocode tests #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timendus
approved these changes
Jul 26, 2025
Owner
Timendus
left a comment
Timendus
left a comment
There was a problem hiding this comment.
Looks great. I thought I had checked for no-op passing these opcodes, but maybe I didn't. It's originally someone else's test after all, so I'll just pass on the blame ;P
|
Hey @Timendus, any chance to merge this? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to enhance the skip opcode tests, as three of them were succeeding if the skip opcode is a no-op.
My changes test each skip with a skipping and a non-skipping test (originally only a non-skipping test was done in most of them) and are ordered in a way that no-op-ing through them will lead to a fail.
This should fix #28 as well.
PS: I additionally added an option to the ffmpeg call that stops an error in the log from appearing on my side, when building the tests. I hope it's universal.