feat: trigger storage pool refresh on buddy group and target deletions (#40)

Author: pranavpadmasali

mgmtd/src/bee_msg/target.rs

@@ -2,6 +2,7 @@ use super::*;
 use crate::db::target::TargetCapacities;
 use crate::types::ResolveEntityId;
 use rusqlite::Transaction;
+use shared::bee_msg::storage_pool::RefreshStoragePools;
 use shared::bee_msg::target::*;
 use std::time::Duration;
 
@@ -170,7 +171,8 @@ impl HandleWithResponse for MapTargets {
 
         let target_ids = self.target_ids.keys().copied().collect::<Vec<_>>();
 
-        ctx.db
+        let updated = ctx
+            .db
             .write_tx(move |tx| {
                 // Check node Id exists
                 let node = LegacyId {
@@ -181,8 +183,9 @@ impl HandleWithResponse for MapTargets {
                 // Check all target Ids exist
                 db::target::validate_ids(tx, &target_ids, NodeTypeServer::Storage)?;
                 // Due to the check above, this must always match all the given ids
-                db::target::update_storage_node_mappings(tx, &target_ids, node.num_id())?;
-                Ok(())
+                let updated =
+                    db::target::update_storage_node_mappings(tx, &target_ids, node.num_id())?;
+                Ok(updated)
             })
             .await?;
 
@@ -205,6 +208,16 @@ impl HandleWithResponse for MapTargets {
         )
         .await;
 
+        // Map targets alter pool membership, so trigger an immediate pool refresh
+        if updated > 0 {
+            notify_nodes(
+                ctx,
+                &[NodeType::Meta, NodeType::Storage],
+                &RefreshStoragePools { ack_id: "".into() },
+            )
+            .await;
+        }
+
         // Storage server expects a separate status code for each target map requested. We, however,
         // do a all-or-nothing approach. If e.g. one target id doesn't exist (which is an
         // exceptional error and should usually not happen anyway), we fail the whole

mgmtd/src/grpc/buddy_group.rs

@@ -7,6 +7,7 @@ use shared::bee_msg::buddy_group::{
     GetStorageResyncStatsResp, RemoveBuddyGroup, RemoveBuddyGroupResp, SetLastBuddyCommOverride,
     SetMetadataMirroring, SetMetadataMirroringResp, SetMirrorBuddyGroup,
 };
+use shared::bee_msg::storage_pool::RefreshStoragePools;
 use shared::bee_msg::target::{RefreshTargetStates, SetTargetConsistencyStatesResp};
 use tokio::time::{Duration, Instant, sleep};
 
@@ -144,6 +145,16 @@ pub(crate) async fn create(
     )
     .await;
 
+    // Storage buddy groups alter pool membership, so trigger an immediate pool refresh
+    if node_type == NodeTypeServer::Storage {
+        notify_nodes(
+            &ctx,
+            &[NodeType::Meta, NodeType::Storage],
+            &RefreshStoragePools { ack_id: "".into() },
+        )
+        .await;
+    }
+
     Ok(pm::CreateBuddyGroupResponse {
         group: Some(group.into()),
     })
@@ -220,6 +231,14 @@ Primary result: {:?}, Secondary result: {:?}",
 
     if execute {
         log::info!("Buddy group deleted: {group}");
+
+        // Storage buddy groups alter pool membership, so trigger an immediate pool refresh
+        notify_nodes(
+            &ctx,
+            &[NodeType::Meta, NodeType::Storage],
+            &RefreshStoragePools { ack_id: "".into() },
+        )
+        .await;
     }
 
     Ok(pm::DeleteBuddyGroupResponse {

mgmtd/src/grpc/target.rs

@@ -2,6 +2,7 @@ use super::*;
 use crate::cap_pool::{CapPoolCalculator, CapacityInfo};
 use shared::bee_msg::OpsErr;
 use shared::bee_msg::misc::RefreshCapacityPools;
+use shared::bee_msg::storage_pool::RefreshStoragePools;
 use shared::bee_msg::target::{
     RefreshTargetStates, SetTargetConsistencyStates, SetTargetConsistencyStatesResp,
 };
@@ -215,6 +216,14 @@ pub(crate) async fn delete(
             &RefreshCapacityPools { ack_id: "".into() },
         )
         .await;
+
+        // Storage targets deletion alter pool membership, so trigger an immediate pool refresh
+        notify_nodes(
+            &ctx,
+            &[NodeType::Meta, NodeType::Storage],
+            &RefreshStoragePools { ack_id: "".into() },
+        )
+        .await;
     }
 
     let target = Some(target.into());