Skip to content

Commit b951465

Browse files
Simplified DummyClass by removing unused dependencies and attributes
1 parent 2ca96e7 commit b951465

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

dev/ide.json

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,27 @@
2121
}
2222
}
2323
]
24+
},
25+
{
26+
"id": "dragon-code.feeds.converter",
27+
"name": "Create Feed Converter",
28+
"classSuffix": "Converter",
29+
"regex": ".+",
30+
"files": [
31+
{
32+
"appNamespace": "Converters",
33+
"name": "${INPUT_CLASS|replace: ,_|className|upperCamelCase}.php",
34+
"template": {
35+
"type": "stub",
36+
"path": "/stubs/converter.stub",
37+
"fallbackPath": "stubs/converter.stub",
38+
"parameters": {
39+
"DummyNamespace": "${INPUT_FQN|namespace}",
40+
"DummyClass": "${INPUT_CLASS|replace: ,_|className|upperCamelCase}"
41+
}
42+
}
43+
}
44+
]
2445
}
2546
]
2647
}

stubs/converter.stub

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,12 @@ namespace DummyNamespace;
77
use DragonCode\LaravelFeed\Converters\Converter;
88
use DragonCode\LaravelFeed\Feeds\Feed;
99
use DragonCode\LaravelFeed\Feeds\Items\FeedItem;
10-
use DragonCode\LaravelFeed\Services\TransformerService;
11-
use Illuminate\Container\Attributes\Config;
1210

11+
use function implode;
1312
use function is_array;
14-
use function json_encode;
1513

1614
class DummyClass extends Converter
1715
{
18-
public function __construct(
19-
#[Config('feeds.converters.jsonl.options')]
20-
protected int $options,
21-
TransformerService $transformer
22-
) {
23-
parent::__construct(false, $transformer);
24-
}
25-
2616
public function header(Feed $feed): string
2717
{
2818
return '';
@@ -69,6 +59,6 @@ class DummyClass extends Converter
6959

7060
protected function encode(array $data): string
7161
{
72-
return json_encode($data, $this->options);
62+
return implode(';', $data);
7363
}
7464
}

0 commit comments

Comments
 (0)