From 2fd40446d494e2f203f20616e2fd8915b86ff1e0 Mon Sep 17 00:00:00 2001 From: realstealthninja <68815218+realstealthninja@users.noreply.github.com> Date: Sat, 27 Sep 2025 12:22:26 +0530 Subject: [PATCH 1/2] chore: fix file formatter --- scripts/file_linter.py | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/scripts/file_linter.py b/scripts/file_linter.py index 8414221b829..910bad6ce2d 100644 --- a/scripts/file_linter.py +++ b/scripts/file_linter.py @@ -6,18 +6,33 @@ with open("git_diff.txt") as in_file: modified_files = sorted(in_file.read().splitlines()) print("{} files were modified.".format(len(modified_files))) - + cpp_exts = tuple(".c .c++ .cc .cpp .cu .cuh .cxx .h .h++ .hh .hpp .hxx".split()) cpp_files = [file for file in modified_files if file.lower().endswith(cpp_exts)] print(f"{len(cpp_files)} C++ files were modified.") if not cpp_files: sys.exit(0) + else: + subprocess.run( + [ + "clang-tidy", + "--fix", + "-p=build", + "--extra-arg=-std=c++11", + *cpp_files, + "--", + ], + check=True, + text=True, + stderr=subprocess.STDOUT, + ) - subprocess.run(["clang-tidy", "--fix", "-p=build", "--extra-arg=-std=c++11", *cpp_files, "--"], - check=True, text=True, stderr=subprocess.STDOUT) - - subprocess.run(["clang-format", "-i", "-style=file", *cpp_files], - check=True, text=True, stderr=subprocess.STDOUT) + subprocess.run( + ["clang-format", "-i", "-style=file", *cpp_files], + check=True, + text=True, + stderr=subprocess.STDOUT, + ) upper_files = [file for file in cpp_files if file != file.lower()] if upper_files: From e9c5e6eca01131059c603b97f786eda24d0bd565 Mon Sep 17 00:00:00 2001 From: realstealthninja <68815218+realstealthninja@users.noreply.github.com> Date: Sat, 27 Sep 2025 12:29:05 +0530 Subject: [PATCH 2/2] chore: remove else and make it a guard clause as it was initally --- scripts/file_linter.py | 73 ++++++++++++++++++++---------------------- 1 file changed, 34 insertions(+), 39 deletions(-) diff --git a/scripts/file_linter.py b/scripts/file_linter.py index 910bad6ce2d..cfa98a4b93f 100644 --- a/scripts/file_linter.py +++ b/scripts/file_linter.py @@ -12,43 +12,38 @@ print(f"{len(cpp_files)} C++ files were modified.") if not cpp_files: sys.exit(0) - else: - subprocess.run( - [ - "clang-tidy", - "--fix", - "-p=build", - "--extra-arg=-std=c++11", - *cpp_files, - "--", - ], - check=True, - text=True, - stderr=subprocess.STDOUT, - ) - subprocess.run( - ["clang-format", "-i", "-style=file", *cpp_files], - check=True, - text=True, - stderr=subprocess.STDOUT, - ) - - upper_files = [file for file in cpp_files if file != file.lower()] - if upper_files: - print(f"{len(upper_files)} files contain uppercase characters:") - print("\n".join(upper_files) + "\n") - - space_files = [file for file in cpp_files if " " in file or "-" in file] - if space_files: - print(f"{len(space_files)} files contain space or dash characters:") - print("\n".join(space_files) + "\n") - - nodir_files = [file for file in cpp_files if file.count(os.sep) != 1] - if nodir_files: - print(f"{len(nodir_files)} files are not in one and only one directory:") - print("\n".join(nodir_files) + "\n") - - bad_files = len(upper_files + space_files + nodir_files) - if bad_files: - sys.exit(bad_files) + subprocess.run( + [ + "clang-tidy", + "--fix", + "-p=build", + "--extra-arg=-std=c++11", + *cpp_files, + "--", + ], + check=True, + text=True, + stderr=subprocess.STDOUT, + ) + subprocess.run( + ["clang-format", "-i", "-style=file", *cpp_files], + check=True, + text=True, + stderr=subprocess.STDOUT, + ) + upper_files = [file for file in cpp_files if file != file.lower()] + if upper_files: + print(f"{len(upper_files)} files contain uppercase characters:") + print("\n".join(upper_files) + "\n") + space_files = [file for file in cpp_files if " " in file or "-" in file] + if space_files: + print(f"{len(space_files)} files contain space or dash characters:") + print("\n".join(space_files) + "\n") + nodir_files = [file for file in cpp_files if file.count(os.sep) != 1] + if nodir_files: + print(f"{len(nodir_files)} files are not in one and only one directory:") + print("\n".join(nodir_files) + "\n") + bad_files = len(upper_files + space_files + nodir_files) + if bad_files: + sys.exit(bad_files)