Session 15: Code Quality - String and Format Optimizations - Major Progress

Fixed major string and format optimization issues by improving efficiency and readability:
- Fixed csv.rs: Replaced format! appended to String with write! macro (4 instances)
  - Classes summary, Slots summary, Enums summary, Types summary
  - Used write! with expect() for proper error handling in String-returning functions
- Fixed excel.rs: Used direct variable interpolation in format! strings (3 instances)
  - Column count validation, Column index validation, Validation value range
- Fixed jsonld_context.rs: Used direct variable interpolation for slot name conflicts
- Fixed json_schema.rs: Used direct variable interpolation for unknown type errors
- Improved memory efficiency by avoiding unnecessary string allocations
- Enhanced code readability with modern Rust format string syntax

Reduced format/string warnings from 33 to 31
Core library compiles cleanly
Current clippy warnings in core lib: 766 (reduced from 771)

Author: simonckemper

linkml-service/src/generator/csv.rs

@@ -255,44 +255,48 @@ impl CsvGenerator {
         }
 
         // Classes
-        output.push_str(&format!(
+        write!(
+            output,
             "Class{}{}{}Schema classes{}{}\n",
             self.delimiter,
             self.delimiter,
             self.delimiter,
             self.delimiter,
             schema.classes.len()
-        ));
+        ).expect("Failed to write to string");
 
         // Slots
-        output.push_str(&format!(
+        write!(
+            output,
             "Slot{}{}{}Schema slots{}{}\n",
             self.delimiter,
             self.delimiter,
             self.delimiter,
             self.delimiter,
             schema.slots.len()
-        ));
+        ).expect("Failed to write to string");
 
         // Enums
-        output.push_str(&format!(
+        write!(
+            output,
             "Enum{}{}{}Schema enumerations{}{}\n",
             self.delimiter,
             self.delimiter,
             self.delimiter,
             self.delimiter,
             schema.enums.len()
-        ));
+        ).expect("Failed to write to string");
 
         // Types
-        output.push_str(&format!(
+        write!(
+            output,
             "Type{}{}{}Schema types{}{}\n",
             self.delimiter,
             self.delimiter,
             self.delimiter,
             self.delimiter,
             schema.types.len()
-        ));
+        ).expect("Failed to write to string");
 
         output
     }

linkml-service/src/generator/excel.rs

@@ -31,13 +31,13 @@ mod excel_cast {
 
         if value >= MAX_EXCEL_COLUMNS {
             return Err(GeneratorError::Generation(
-                format!("Too many columns for Excel: {} (max: {})", value, MAX_EXCEL_COLUMNS)
+                format!("Too many columns for Excel: {value} (max: {MAX_EXCEL_COLUMNS})")
             ));
         }
 
         u16::try_from(value).map_err(|_| {
             GeneratorError::Generation(
-                format!("Column index {} cannot fit in u16", value)
+                format!("Column index {value} cannot fit in u16")
             )
         })
     }
@@ -47,7 +47,7 @@ mod excel_cast {
     pub fn i64_to_i32_validation(value: i64) -> Result<i32, GeneratorError> {
         i32::try_from(value).map_err(|_| {
             GeneratorError::Generation(
-                format!("Validation value {} is outside i32 range", value)
+                format!("Validation value {value} is outside i32 range")
             )
         })
     }

linkml-service/src/generator/json_schema.rs

@@ -172,8 +172,7 @@ impl JsonSchemaGenerator {
                     // Check if we should error on unknown types
                     if self.options.custom.get("strict_types").map(|v| v == "true").unwrap_or(false) {
                         Err(GeneratorError::SchemaValidation(format!(
-                            "Unknown type '{}' - not found in enums, classes, or types",
-                            other
+                            "Unknown type '{other}' - not found in enums, classes, or types"
                         )))
                     } else {
                         // Default to string with warning comment

linkml-service/src/generator/jsonld_context.rs

@@ -173,7 +173,7 @@ impl JsonLdContextGenerator {
         // Validate slot name doesn't conflict with JSON-LD keywords
         if ["@context", "@id", "@type", "@value", "@language", "@index", "@reverse", "@graph"].contains(&slot_name) {
             return Err(LinkMLError::data_validation(
-                format!("Slot name '{}' conflicts with JSON-LD keyword", slot_name)
+                format!("Slot name '{slot_name}' conflicts with JSON-LD keyword")
             ));
         }