Maybe a bug in function compute_modulus in Class DistributedPaillier

[Jinstorm]

At https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1231, in Class DistributedPaillier class function compute_modulus .

Should it be shares.p = Shares.P(p_additive[i], prime_candidate_p[i].get_shares()) instead? To replace prime_candidate_q[i].get_share()

[Quitlox]

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

[ThomasTNO]

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

@Quitlox, you sure about that? https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1344C1-L1345C84

Still seems broken in latest.

[Quitlox]

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

@Quitlox, you sure about that? https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1344C1-L1345C84

Still seems broken in latest.

Not that version unfortunately, it's still in the works.