Skip to content

Commit f4059a9

Browse files
committed
Remove incorrect inheritence of external for signals.
1 parent 686fdb7 commit f4059a9

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/systemrdl/__about__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "1.29.1"
1+
__version__ = "1.29.2"

src/systemrdl/core/elaborate.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -565,12 +565,8 @@ def enter_Field(self, node: FieldNode) -> None:
565565
node.inst.external = node.parent.inst.external
566566

567567
def enter_Signal(self, node: SignalNode) -> None:
568-
if isinstance(node.parent, RootNode):
569-
# In root scope. External is meaningless, so assign it to False
570-
node.inst.external = False
571-
else:
572-
assert node.parent is not None
573-
node.inst.external = node.parent.inst.external
568+
# External is meaningless for signals. Always False
569+
node.inst.external = False
574570

575571
def enter_Regfile(self, node: RegfileNode) -> None:
576572
if self.coerce_external_to is not None:

0 commit comments

Comments
 (0)