Fix type inference test

Author: MilesCranmer

src/BaseType.jl

@@ -20,9 +20,9 @@ For example,
 ]
 ```
 """
-function base_numeric_type(x::Type)
-    params = x isa UnionAll ? x.body.parameters : x.parameters
-    return length(params) == 0 ? x : first(params)
+function base_numeric_type(::Type{T}) where {T}
+    params = T isa UnionAll ? T.body.parameters : T.parameters
+    return isempty(params) ? T : first(params)
 end
 base_numeric_type(x) = base_numeric_type(typeof(x))
 

test/unittests.jl

@@ -7,7 +7,6 @@ using StaticArrays: StaticArrays
 using Unitful: Unitful
 
 expected_type_pairs = [
-    Float32 => Float32,
     Float32 => Float32,
     Array{Float64,1} => Float64,
     ComplexF64 => Float64,
@@ -26,7 +25,7 @@ expected_type_pairs = [
 for (x, y) in expected_type_pairs
     @eval @test base_numeric_type($x) == $y
     # Make sure compiler can inline it:
-    @eval @inferred typeof($y) base_numeric_type($x)
+    @eval @inferred $y base_numeric_type($x)
 end
 
 @test base_numeric_type(1.5DynamicQuantities.u"km/s") == base_numeric_type(typeof(1.5DynamicQuantities.u"km/s"))