Skip to content

Commit ea4a2f7

Browse files
Remove google.generativeai dependency
The dep is not compatible with DA 1.8.X due to further dependency chain conflicts. Just removing the python dependency will fix issues with those versions, while allowing the feature to still work on DA 1.7.X and below. Does add some quick documentation about the feature on the README page, so the feature doesn't disappear into "code only" documentation. In the future, could consider using optional dependencies (https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements) and packaging extras to still allow folks to install the gen ai dependency with `docassemble.GitHubFeedback[genai]`. This will be simpler once we transition to `pyproject.toml`, which only has good support in DA 1.8.X. Fix #74.
1 parent a49b8e8 commit ea4a2f7

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ This package is designed to support the following workflow:
3434
feedback session linking: True
3535
# Will ask users filling in feedback if they want to be in a panel, and get their email if they want to
3636
ask panel: True
37+
# (optional) If you need better protection from spam feedback,
38+
# adding the below, and installing the `google.generativeai` package
39+
# will use Gemini AI as an additional filter.
40+
google gemini api key: ...
41+
spam model: "gemini-2.0-flash-exp" # the default
3742
```
3843
3944
Note that it is important to provide a list of allowed repository owners.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def find_package_data(where='.', package='', exclude=standard_exclude, exclude_d
5252
license='The MIT License (MIT)',
5353
url='https://courtformsonline.org',
5454
packages=find_namespace_packages(),
55-
install_requires=['docassemble.ALToolbox>=0.6.0', 'google-generativeai'],
55+
install_requires=['docassemble.ALToolbox>=0.6.0'],
5656
zip_safe=False,
5757
package_data=find_package_data(where='docassemble/GithubFeedbackForm/', package='docassemble.GithubFeedbackForm'),
5858
)

0 commit comments

Comments
 (0)