Skip to content

Commit b8c7eb4

Browse files
Fix silent validation DA issue with panel question
Docassemble has issues with certain show if'd fields being required. For some reason, hiding one field behind a show-if from a server config, and then hiding other fields behind that field caused validation issues for with latter fields, which shows no user indication becasue those fields aren't shown. Fixed the issue by using the same server show if code on all of the fields. A bit redandant, it does fix the issue in my testing. Fix #48
1 parent 2854db4 commit b8c7eb4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

docassemble/GithubFeedbackForm/data/questions/feedback.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,8 @@ fields:
131131
- note: |
132132
We will contact you for the feedback panel by email.
133133
show if:
134+
code: |
135+
server_ask_panel and not get_config('debug')
134136
variable: would_be_on_panel
135137
is: True
136138
- label: |
@@ -139,6 +141,8 @@ fields:
139141
datatype: email
140142
default: ${ user_info().email if hasattr(user_info(), 'email') else '' }
141143
show if:
144+
code: |
145+
server_ask_panel and not get_config('debug')
142146
variable: would_be_on_panel
143147
is: True
144148
continue button field: intro

0 commit comments

Comments
 (0)