Skip to content

Commit 933dc1f

Browse files
Always make a link to make a new GitHub issue
Not an automated process, so the concerns of making unwanted issues on someone's repo aren't valid, the resposibility is on the GitHub user who manually clicks on the link. Fixes #64.
1 parent fc14290 commit 933dc1f

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

docassemble/GithubFeedbackForm/github_issue.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ def prefill_github_issue_url(
322322
title=None,
323323
body=None,
324324
label=None,
325-
) -> Optional[str]:
325+
) -> str:
326326
"""
327327
Makes a URL that when visited, pre-fills part of the Github issue. It doesn't automatically make a Github issue for you.
328328
@@ -337,12 +337,6 @@ def prefill_github_issue_url(
337337
)
338338
if not repo_name:
339339
repo_name = "docassemble-AssemblyLine" # TODO(brycew): should this be the default repo? it is in `feedback.yml`
340-
# TODO(brycew): this function doesn't make issues: do we still want to prevent making URLs for other repos?
341-
if repo_owner.lower() not in _get_allowed_repo_owners():
342-
log(
343-
f"Error creating issue: this form is not permitted to add issues to repositories owned by {repo_owner}. Check your config and see https://github.com/SuffolkLITLab/docassemble-GithubFeedbackForm#getting-started"
344-
)
345-
return None
346340

347341
if template:
348342
title = template.subject

0 commit comments

Comments
 (0)