Commit 3e64bee
authored
Don't disable existing loggers when Alembic runs (#65)
Python's documentation about this
https://docs.python.org/3/library/logging.config.html#logging.config.fileConfig.
Alembic auto-generates this file, but I can't find other uses of it in
Suffolk code (@nonprofittechy, I suggest you check LemmaLegal packages).
Found by finding that when logs were broken on servers (the prod and
sometimes dev servers), `docassemble.webapps.server.sys_log.disabled ==
True`. Consulted https://stackoverflow.com/a/43279730/11416267 once I
discovered that.
Tested and confirmed fixed locally on a localhost docassemble with the
following (no good unit test :
* restart docassemble's python code (by saving the config and restarting
the server)
* confirm the logs work by loading an interview with a unique log
message, checking it's timestamp
* run the `GithubFeedbackForm/feedback.yml` interview
* on older versions, no more logs will be output after that
* on this fixed version, you should be able to trigger and see new logs1 parent f3d37d5 commit 3e64bee
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments