Updated cache handling with Doctrine/ArrayCache as default

Author: TristanPerchec

CompilerPass/DynamicServiceCacheCompilerPass.php

@@ -22,7 +22,7 @@ public function process(ContainerBuilder $container)
         if ($container->getParameter('zoho_subscription.cache.service') !== null) {
             $container
                 ->getDefinition('zoho.api.manager')
-                ->addArgument(new Reference($container->getParameter('zoho_subscription.cache.service')))
+                ->replaceArgument(2, new Reference($container->getParameter('zoho_subscription.cache.service')))
             ;
         }
     }

DependencyInjection/Configuration.php

@@ -36,13 +36,9 @@ public function getConfigTreeBuilder()
                 ->end()
                 ->arrayNode('cache')
                     ->children()
-                        ->booleanNode('enabled')
-                            ->info('If cache is active or not')
-                            ->defaultValue(false)
-                        ->end()
                         ->scalarNode('service')
                             ->info('Defines the service id of the cache that will be used')
-                            ->defaultValue(null)
+                            ->defaultValue('zoho.array.cache')
                         ->end()
                         ->integerNode('ttl')
                             ->info('Defines the TTL of the cache')

DependencyInjection/ZohoSubscriptionExtension.php

@@ -28,7 +28,6 @@ public function load(array $configs, ContainerBuilder $container)
         $container->setParameter('zoho_subscription.api_key', $config['api']['key']);
         $container->setParameter('zoho_subscription.org_id', $config['api']['organization_id']);
         $container->setParameter('zoho_subscription.cache.service', $config['cache']['service']);
-        $container->setParameter('zoho_subscription.cache.enabled', $config['cache']['enabled']);
         $container->setParameter('zoho_subscription.cache.ttl', $config['cache']['ttl']);
     }
 }

Resources/config/services.xml

@@ -8,13 +8,15 @@
             <argument>%zoho_subscription.api_key%</argument>
             <argument>%zoho_subscription.org_id%</argument>
             <argument>%zoho_subscription.cache.enabled%</argument>
-            <argument></argument>
+            <argument>null</argument>
             <argument>%zoho_subscription.cache.ttl%</argument>
         </service>
 
         <service id="zoho.api.addon" class="Zoho\Subscription\Api\Addon" parent="zoho.api.manager"></service>
         <service id="zoho.api.plan" class="Zoho\Subscription\Api\Plan" parent="zoho.api.manager"></service>
 
+        <service id="zoho.array.cache" class="Doctrine\Common\Cache\ArrayCache"></service>
+
 
     </services>
 </container>