Changed partition assignments to None when new partitions is created #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… responsible for assigning replicas to brokers, when new partitions is created
Owner
|
Thank you. I am wondering if that change is valid for all Kafka versions, I kind of remember this was needed when I first developed this lib (a looong time ago...). Let's see how the tests run. |
Owner
|
Looks very good to me. Thanks again, |
StephenSorriaux
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, custom partition reassignment is used when new partitions is created.
In case of using of rack awareness custom reassignment is not allowed to rely on
broker.rackproperty because it bypasses the rack-aware assignment logic and can lead to rack-aware violations.According to https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/NewPartitions.java#L43 setting custom partition reassignment is not necessary and controller would be responsible for assigning replicas to brokers for existing topics.
Fixes #
Proposed Changes