Fix n_updates counting with early stopping in MaskablePPO and RecurrentPPO #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect
n_updatescounting in bothMaskablePPOandRecurrentPPOwhen early stopping is triggered due to thetarget_klthreshold.The Problem:
n_updateswas always incremented by the fulln_epochsvalue (default: 10) regardless of actual epochs completedtarget_kltriggered early stopping (e.g., at epoch 5),n_updateswould still increment by 10 instead of 5The Solution:
n_updatesincrement inside the epoch loop to count only completed epochsn_updatesby 1, matching the behavior of base PPOFiles Changed:
sb3_contrib/ppo_mask/ppo_mask.pysb3_contrib/ppo_recurrent/ppo_recurrent.pyTesting
The fix has been verified with:
Impact