Skip to content

Conversation

@imhayatunnabi
Copy link

@imhayatunnabi imhayatunnabi commented Nov 8, 2025

1️⃣ Why should it be added? What are the benefits of this change?

  1. TSV Files Work Correctly: Add automatic TSV tab delimiter detection for proper TSV file handling
  2. Queued Exports No Longer Crash: Undefined variable $sheetExport causing fatal errors in queued export jobs
  3. PHP 8+ Named Parameters Support: Interface parameter names didn't match implementation

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No, these changes are closely related and should be kept together: All three fixes address core functional bugs in the Excel processing pipeline

3️⃣ Does it include tests, if possible?
The existing test suite validates these fixes:

4️⃣ Any drawbacks? Possible breaking changes?
Zero Breaking Changes - Fully Backward Compatible

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant