Skip to content

Commit 9cd9bf0

Browse files
author
Corey McCormick
committed
Merge branch 'develop' of https://github.com/SimpleSoftwareIO/simple-qrcode into develop
2 parents 0da02d9 + 8f48a61 commit 9cd9bf0

File tree

7 files changed

+330
-232
lines changed

7 files changed

+330
-232
lines changed

docs/ru/README.md

Lines changed: 309 additions & 212 deletions
Large diffs are not rendered by default.

src/DataTypes/Email.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ protected function setEmail($email)
113113
*/
114114
protected function isValidEmail($email)
115115
{
116-
if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
116+
if (! filter_var($email, FILTER_VALIDATE_EMAIL)) {
117117
throw new InvalidArgumentException('Invalid email provided');
118118
}
119119

src/Facade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Illuminate\Support\Facades\Facade;
66

7-
class QrCode extends Facade
7+
class Facade extends Facade
88
{
99
/**
1010
* Get the registered name of the component.

src/Generator.php

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use BaconQrCode\Exception\WriterException;
88
use BaconQrCode\Renderer\Color\Alpha;
99
use BaconQrCode\Renderer\Color\ColorInterface;
10+
use BaconQrCode\Renderer\Color\Gray;
1011
use BaconQrCode\Renderer\Color\Rgb;
1112
use BaconQrCode\Renderer\Eye\EyeInterface;
1213
use BaconQrCode\Renderer\Eye\ModuleEye;
@@ -18,17 +19,17 @@
1819
use BaconQrCode\Renderer\Module\ModuleInterface;
1920
use BaconQrCode\Renderer\Module\RoundnessModule;
2021
use BaconQrCode\Renderer\Module\SquareModule;
21-
use BaconQrCode\Renderer\RendererStyle\Fill;
22-
use BaconQrCode\Renderer\RendererStyle\RendererStyle;
23-
use BaconQrCode\Writer;
24-
use InvalidArgumentException;
2522
use BaconQrCode\Renderer\Image\EpsImageBackEnd;
2623
use BaconQrCode\Renderer\Image\ImageBackEndInterface;
2724
use BaconQrCode\Renderer\Image\ImagickImageBackEnd;
2825
use BaconQrCode\Renderer\RendererStyle\EyeFill;
26+
use BaconQrCode\Renderer\RendererStyle\Fill;
2927
use BaconQrCode\Renderer\RendererStyle\Gradient;
3028
use BaconQrCode\Renderer\RendererStyle\GradientType;
29+
use BaconQrCode\Renderer\RendererStyle\RendererStyle;
30+
use BaconQrCode\Writer;
3131
use BadMethodCallException;
32+
use InvalidArgumentException;
3233
use SimpleSoftwareIO\QrCode\DataTypes\DataTypeInterface;
3334

3435
class Generator
@@ -71,7 +72,7 @@ class Generator
7172
* ISO-8859-7, ISO-8859-8, ISO-8859-9, ISO-8859-10, ISO-8859-11,
7273
* ISO-8859-12, ISO-8859-13, ISO-8859-14, ISO-8859-15, ISO-8859-16,
7374
* SHIFT-JIS, WINDOWS-1250, WINDOWS-1251, WINDOWS-1252, WINDOWS-1256,
74-
* UTF-16BE, UTF-8, ASCII, GBK, EUC-KR
75+
* UTF-16BE, UTF-8, ASCII, GBK, EUC-KR.
7576
*
7677
* @var string
7778
*/
@@ -168,7 +169,7 @@ public function __call($method, array $arguments)
168169
*/
169170
public function generate(string $text, string $filename = null)
170171
{
171-
$qrCode = $this->getWriter($this->getRenderer())->writeString($text, $this->encoding, $this->errorCorrection);
172+
$qrCode = $this->getWriter($this->getRenderer())->writeString($text, $this->encoding, $this->errorCorrection);
172173

173174
if ($this->imageMerge !== null && $this->format === 'png') {
174175
$merger = new ImageMerge(new Image($qrCode), new Image($this->imageMerge));
@@ -177,6 +178,7 @@ public function generate(string $text, string $filename = null)
177178

178179
if ($filename) {
179180
file_put_contents($filename, $qrCode);
181+
180182
return;
181183
}
182184

@@ -193,7 +195,7 @@ public function generate(string $text, string $filename = null)
193195
*/
194196
public function merge(string $filepath, float $percentage = .2, bool $absolute = false): self
195197
{
196-
if (function_exists('base_path') && !$absolute) {
198+
if (function_exists('base_path') && ! $absolute) {
197199
$filepath = base_path().$filepath;
198200
}
199201

@@ -204,7 +206,7 @@ public function merge(string $filepath, float $percentage = .2, bool $absolute =
204206
}
205207

206208
/**
207-
* Merges an image string with the center of the QrCode
209+
* Merges an image string with the center of the QrCode.
208210
*
209211
* @param string $content
210212
* @param float $percentage
@@ -370,7 +372,7 @@ public function style(string $style, float $size = 0.5): self
370372
* ISO-8859-7, ISO-8859-8, ISO-8859-9, ISO-8859-10, ISO-8859-11,
371373
* ISO-8859-12, ISO-8859-13, ISO-8859-14, ISO-8859-15, ISO-8859-16,
372374
* SHIFT-JIS, WINDOWS-1250, WINDOWS-1251, WINDOWS-1252, WINDOWS-1256,
373-
* UTF-16BE, UTF-8, ASCII, GBK, EUC-KR
375+
* UTF-16BE, UTF-8, ASCII, GBK, EUC-KR.
374376
*
375377
* @param string $encoding
376378
* @return Generator
@@ -421,7 +423,7 @@ public function margin(int $margin): self
421423
*/
422424
public function getWriter(ImageRenderer $renderer): Writer
423425
{
424-
return (new Writer($renderer));
426+
return new Writer($renderer);
425427
}
426428

427429
/**
@@ -475,11 +477,11 @@ public function getFormatter(): ImageBackEndInterface
475477
public function getModule(): ModuleInterface
476478
{
477479
if ($this->style === 'dot') {
478-
return (new DotsModule($this->styleSize));
480+
return new DotsModule($this->styleSize);
479481
}
480482

481483
if ($this->style === 'round') {
482-
return (new RoundnessModule($this->styleSize));
484+
return new RoundnessModule($this->styleSize);
483485
}
484486

485487
return SquareModule::instance();
@@ -500,7 +502,7 @@ public function getEye(): EyeInterface
500502
return SimpleCircleEye::instance();
501503
}
502504

503-
return (new ModuleEye($this->getModule()));
505+
return new ModuleEye($this->getModule());
504506
}
505507

506508
/**
@@ -536,7 +538,7 @@ public function createColor(int $red, int $green, int $blue, ?int $alpha = null)
536538
if (! $alpha) {
537539
return new Rgb($red, $green, $blue);
538540
}
539-
541+
540542
return new Alpha($alpha, new Rgb($red, $green, $blue));
541543
}
542544

@@ -550,7 +552,7 @@ protected function createClass(string $method): DataTypeInterface
550552
{
551553
$class = $this->formatClass($method);
552554

553-
if (!class_exists($class)) {
555+
if (! class_exists($class)) {
554556
throw new BadMethodCallException();
555557
}
556558

src/ServiceProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Illuminate\Support\ServiceProvider;
66

7-
class QrCodeServiceProvider extends ServiceProvider
7+
class ServiceProvider extends ServiceProvider
88
{
99
/**
1010
* Indicates if loading of the provider is deferred.

tests/DataTypes/EmailTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function test_it_generates_the_proper_format_when_only_a_subject_is_provi
4949
public function test_it_throws_an_exception_when_an_invalid_email_is_given()
5050
{
5151
$this->expectException(InvalidArgumentException::class);
52-
52+
5353
$this->email->create(['foo']);
5454
}
5555
}

tests/GeneratorTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use BaconQrCode\Renderer\RendererStyle\Gradient;
1212
use BaconQrCode\Renderer\RendererStyle\RendererStyle;
1313
use PHPUnit\Framework\TestCase;
14-
use SimpleSoftwareIO\QrCode\Generator;
1514

1615
class GeneratorTest extends TestCase
1716
{

0 commit comments

Comments
 (0)